RFR: 8373936: RichEditorDemoApp enhancements [v4]
Andy Goryachev
angorya at openjdk.org
Wed Jan 28 20:16:02 UTC 2026
On Wed, 28 Jan 2026 11:04:37 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into 8373936.editor
>> - actions
>> - Merge branch 'master' into 8373936.editor
>> - Merge branch 'master' into 8373936.editor
>> - Merge branch 'master' into 8373936.editor
>> - whitespace
>> - whitespace
>> - Merge branch '8374035.insert.styles' into 8373936.editor
>> - 2026
>> - Merge branch 'master' into 8374035.insert.styles
>> - ... and 27 more: https://git.openjdk.org/jfx/compare/422d3a95...df6dbb17
>
> Looks good, runs good as well! I left one very minor nitpicky comment.
Thank you @lukostyra and @Ziad-Mid for reviewing!
> apps/samples/RichTextAreaDemo/src/com/oracle/demo/richtext/editor/Actions.java line 493:
>
>> 491: return;
>> 492: } else if (start.equals(end)) {
>> 493: return;
>
> Minor: could technically merge this if-else block into one
>
>
> if (start == null || start.equals(end)) {
> return;
> }
you are right, but sometimes keeping things on separate lines helps when stepping through in a debugger. with your permission, I'll keep it as is since it's just a demo app.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/2026#issuecomment-3813676275
PR Review Comment: https://git.openjdk.org/jfx/pull/2026#discussion_r2738428084
More information about the openjfx-dev
mailing list