RFR: 8338145: ComboBox popup is in wrong location on first showing [v3]
Ambarish Rapte
arapte at openjdk.org
Thu Jan 29 09:32:27 UTC 2026
On Wed, 21 Jan 2026 12:15:38 GMT, Christopher Schnick <duke at openjdk.org> wrote:
>> The resize method in the combo box skin does not take into account whether the popup was autofixed or not. This causes a wrong position if the content size is changed, which it often is on initial show.
>>
>> If anyone has a better idea how to actually determine whether a popup was autofixed, then I can improve the check. Currently it relies purely on the popup position and the combo box position.
>>
>> I tested this fix manually on Windows with a reproducer and it works as expected there
>
> Christopher Schnick has updated the pull request incrementally with two additional commits since the last revision:
>
> - Update comments
> - Improve positioning
lgtm+
-------------
Marked as reviewed by arapte (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/2044#pullrequestreview-3721581002
More information about the openjfx-dev
mailing list