<div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New"">- the screenshots are outdated, using much older version of Eclipse, the UI has been changed a bit. The latest Eclipse won't work with java19 without a separate plugin, but i am sure they will fix it soon.</span></p></blockquote><div> </div><div>Yes, I will need to delete all the projects and re-import in order to create the new screenshot. The separate plugin support is explained under "Configure Eclipse to use the latest JDK". Each Eclipse release requires a plugin for the simultaneously released Java version, It is "fixed" in the next version, but then you need another plugin for the new release.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New""><u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New"">- there is an option to 'ignore projects already in the workspace' and I think it must be turned on (I was getting a warning).</span></p></blockquote><div><br></div><div>If you are importing for the first time, no project will already be in the workspace, so it doesn't matter. If you are re-importing it's up to you if you want to ignore them or not, I would say.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="font-family:"Courier New";font-size:14.6667px">- we probably should mention that the gradle build should be run after initial checkout, including </span><b style="font-family:"Courier New";font-size:14.6667px">sdk</b><span style="font-family:"Courier New";font-size:14.6667px"> and </span><b style="font-family:"Courier New";font-size:14.6667px">apps</b><span style="font-family:"Courier New";font-size:14.6667px">. This will load and build the dependencies (lucene).</span><br></blockquote><div><br></div><div>That is explained in the main page - <a href="https://wiki.openjdk.org/display/OpenJFX/Building+OpenJFX">https://wiki.openjdk.org/display/OpenJFX/Building+OpenJFX</a>, or at least should be, as it isn't an Eclipse-specific step. There is a mention of this in the Using Eclipse section.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Nov 15, 2022 at 6:54 PM Andy Goryachev <<a href="mailto:andy.goryachev@oracle.com">andy.goryachev@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg3398403894956098952">
<div lang="EN-US" style="overflow-wrap: break-word;">
<div class="m_3398403894956098952WordSection1">
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New"">Nir, thank you so much!<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New"">A few minor corrections might be needed.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New"">in Import the Eclipse Projects:<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New"">- the screenshots are outdated, using much older version of Eclipse, the UI has been changed a bit. The latest Eclipse won't work with java19 without a separate plugin, but i am
sure they will fix it soon.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New"">- there is an option to 'ignore projects already in the workspace' and I think it must be turned on (I was getting a warning).<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New"">- we probably should mention that the gradle build should be run after initial checkout, including
<b>sdk</b> and <b>apps</b>. This will load and build the dependencies (lucene).<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New"">Perhaps we should also add a section dedicated to configuring error levels, as the default configuration turns off important warnings and enables too many unimportant ones.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New"">Thank you again<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New"">-andy<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Courier New""><u></u> <u></u></span></p>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal" style="margin-bottom:12pt"><b><span style="font-size:12pt;color:black">From:
</span></b><span style="font-size:12pt;color:black">openjfx-dev <<a href="mailto:openjfx-dev-retn@openjdk.org" target="_blank">openjfx-dev-retn@openjdk.org</a>> on behalf of Nir Lisker <<a href="mailto:nlisker@openjdk.org" target="_blank">nlisker@openjdk.org</a>><br>
<b>Date: </b>Monday, 2022/11/14 at 18:09<br>
<b>To: </b><a href="mailto:openjfx-dev@openjdk.org" target="_blank">openjfx-dev@openjdk.org</a> <<a href="mailto:openjfx-dev@openjdk.org" target="_blank">openjfx-dev@openjdk.org</a>><br>
<b>Subject: </b>Re: RFR: 8221708 Update Eclipse project files [v4]<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11pt">On Sun, 13 Nov 2022 02:27:55 GMT, John Hendrikx <<a href="mailto:jhendrikx@openjdk.org" target="_blank">jhendrikx@openjdk.org</a>> wrote:<br>
<br>
>> See <a href="https://bugs.openjdk.org/browse/JDK-8221708" target="_blank">https://bugs.openjdk.org/browse/JDK-8221708</a><br>
><br>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:<br>
> <br>
> Fix controls classpath<br>
<br>
I updated <a href="https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-UsingEclipse" target="_blank">
https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-UsingEclipse</a>.<br>
<br>
-------------<br>
<br>
PR: <a href="https://git.openjdk.org/jfx/pull/930" target="_blank">https://git.openjdk.org/jfx/pull/930</a><u></u><u></u></span></p>
</div>
</div>
</div>
</div></blockquote></div>