<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
I filed <a class="moz-txt-link-freetext" href="https://bugs.openjdk.org/browse/JDK-8300697">https://bugs.openjdk.org/browse/JDK-8300697</a> to track this.
In addition to fixing it, I propose to add a very visible warning so
that developers know they are building in this "HAS_JAVAFX_MODULES"
mode, since it could otherwise be a surprise when no standalone
build artifacts are produced.<br>
<br>
-- Kevin<br>
<br>
<br>
<div class="moz-cite-prefix">On 1/19/2023 12:15 PM, Kevin Rushforth
wrote:<br>
</div>
<blockquote type="cite" cite="mid:a8019b74-06d8-5736-ff4e-25778f4847f8@oracle.com">
I'm not sure that will work in general. The more important thing
to note is that we really can't build and run an actual standalone
JavaFX SDK if the JDK already has the javafx.* modules. I'll file
a bug and we can think about possible solutions.<br>
<br>
Basically, though, unless you are intending to build a set of
javafx.* modules to import into your own local custom build of the
JDK, you need to use a boot JDK that doesn't have the javafx.*
modules.<br>
<br>
-- Kevin<br>
<br>
<br>
<div class="moz-cite-prefix">On 1/19/2023 11:45 AM, Scott Palmer
wrote:<br>
</div>
<blockquote type="cite" cite="mid:CAL3e5iHK6crG_BQED3AqU=F1JDR5garK-4At4TZZ8bJ+566_Sg@mail.gmail.com">
<div dir="ltr">I guess --patch-module should be used instead of
--update-module-path ? It seems to be a little more
complicated.</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Jan 19, 2023 at 2:17
PM Scott Palmer <<a href="mailto:swpalmer@gmail.com" moz-do-not-send="true" class="moz-txt-link-freetext">swpalmer@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div dir="ltr">I found the problem. I'm using a build of
OpenJDK from Azul that includes the javafx modules. You
probably aren't, which means the --upgrade-module-path
option isn't being used so there is no conflict with javac
parameters.
<div>I downloaded a JDK17 without the JavaFX modules and
teh build worked.<br>
<div>I think this will have to be fixed somehow or the
documentation needs to change to forbid a JDK with
built-in JavaFX modules. The current attempts in the
build script to deal with existing javafx modules are
not working.</div>
<div> A fix would be better.</div>
</div>
<div><br>
</div>
<div>Scott</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Jan 19, 2023 at
1:29 PM Scott Palmer <<a href="mailto:swpalmer@gmail.com" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">swpalmer@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div dir="ltr">Tried a gradle clean (which works fine
after manually deleting the stale mac_tools.properties
file) and confirmed the build folder was gone from the
graphics module and elsewhere, no difference. I'm
running the gradle wrapper, so it's using Gradle as
defined by the project. I'm also usually on the
bleeding edge with Gradle, so if I didn't use gradlew
it would have been Gradle 8.0-rc-2 :-)
<div><br>
</div>
<div>Scott<br>
<div>
<div><br>
</div>
</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Jan 19, 2023
at 1:20 PM Kevin Rushforth <<a href="mailto:kevin.rushforth@oracle.com" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">kevin.rushforth@oracle.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px
0px
0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div> I recommend removing the entire build
directory (although if you managed to get "gradle
clean" working, then it will do that).<br>
<br>
What version of gradle are you using? You will
need gradle 7.6 to use JDK 19.<br>
<br>
-- Kevin<br>
<br>
<br>
<div>On 1/19/2023 10:17 AM, Scott Palmer wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Tried again with JDK 17.0.5, just
in case... still not working.</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Jan
18, 2023 at 3:18 PM Scott Palmer <<a href="mailto:swpalmer@gmail.com" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">swpalmer@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div dir="ltr">I'm trying to build OpenJFX
on my Mac. I figured out an issue with
the Gradle scripts, they fail if there is
a stale mac_tools.properties file. A
'clean' also fails for the same reason so
you have to manually delete the file to
get it to be re-built. But now the build
fails with the following error:
<div><br>
</div>
<div>> Task :graphics:compileJava
FAILED<br>
You specified both --module-source-path
and a sourcepath. These options are
mutually exclusive. Ignoring sourcepath.<br>
error: option --upgrade-module-path
cannot be used together with --release<br>
Usage: javac <options> <source
files><br>
use --help for a list of possible
options<br>
<br>
FAILURE: Build failed with an exception.</div>
<div><br>
</div>
<div>I'm not sure why I would be seeing
this error if the build is working for
everyone else. I'm using JDK 19.<br>
</div>
<div>
<div><br>
</div>
<div>Any hints?</div>
</div>
<div><br>
</div>
<div>Btw, the Mac section of <a href="https://wiki.openjdk.org/display/OpenJFX/Building+OpenJFX" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">https://wiki.openjdk.org/display/OpenJFX/Building+OpenJFX</a>
still mentions needing Mercurial. I
don't think that's true anymore.</div>
<div><br>
</div>
<div>Regards,</div>
<div><br>
</div>
<div>Scott</div>
</div>
</blockquote>
</div>
</blockquote>
<br>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>