<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Yes it might be worth looking at the possible null reference
warnings. Maybe file an umbrella Task to look through the warnings
and decide what to do with them? I don't think I like the
"SuppressWarnings" as one of the remedies, but we can discuss that
further once we have a list.<br>
<br>
-- Kevin<br>
<br>
<div class="moz-cite-prefix">On 12/4/2023 9:12 AM, Andy Goryachev
wrote:<br>
</div>
<blockquote type="cite" cite="mid:DM5PR1001MB2172F40831B06CE9A0CBA7F6E586A@DM5PR1001MB2172.namprd10.prod.outlook.com">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:"Yu Gothic";
panose-1:2 11 4 0 0 0 0 0 0 0;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}@font-face
{font-family:"Iosevka Fixed SS16";
panose-1:2 0 5 9 3 0 0 0 0 4;}@font-face
{font-family:"Times New Roman \(Body CS\)";
panose-1:2 11 6 4 2 2 2 2 2 4;}@font-face
{font-family:"\@Yu Gothic";
panose-1:2 11 4 0 0 0 0 0 0 0;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Iosevka Fixed SS16";
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}div.WordSection1
{page:WordSection1;}ol
{margin-bottom:0in;}ul
{margin-bottom:0in;}</style>
<div class="WordSection1">
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16"">The last
two are just unnecessary code, I see no problems turning
this warning off.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16"">But the
'potential null access' one, though being a bit overeager,
might warrant a deeper scrutiny, as it might point to real
bugs. I would suggest to turn this warning on and fix or
mark the occurences with "SuppressWarning" where
appropriate.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16"">But you
do have a good point about review cycles.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16"">-andy<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""><o:p> </o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">openjfx-dev
<a class="moz-txt-link-rfc2396E" href="mailto:openjfx-dev-retn@openjdk.org"><openjfx-dev-retn@openjdk.org></a> on behalf of
Kevin Rushforth <a class="moz-txt-link-rfc2396E" href="mailto:kevin.rushforth@oracle.com"><kevin.rushforth@oracle.com></a><br>
<b>Date: </b>Monday, December 4, 2023 at 09:05<br>
<b>To: </b><a class="moz-txt-link-abbreviated" href="mailto:openjfx-dev@openjdk.org">openjfx-dev@openjdk.org</a>
<a class="moz-txt-link-rfc2396E" href="mailto:openjfx-dev@openjdk.org"><openjfx-dev@openjdk.org></a><br>
<b>Subject: </b>Re: eclipse warnings</span><span style="font-size:12.0pt;color:black;mso-ligatures:none"><o:p></o:p></span></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt">We did a
few of these sort of cleanup fixes a year or so ago.<br>
<br>
In general, this sort of cleanup *might* be useful, but
also causes some code churn and takes review cycles to
ensure that there is no unintentional side effect.<br>
<br>
The last two might be OK cleanup tasks, but I wouldn't
make them a high priority. Worth noting is that a
seemingly redundant null check or instanceof check is not
always a bad thing, so I wouldn't clean up all of them.<br>
<br>
The first group is the more interesting one. In some cases
a potential null access can highlight actual bugs.
However, I oppose any automated solution for these, since
adding a null check where you don't expect a null (even if
you IDE thinks it might be possible) can hide the root
cause of a problem.<br>
<br>
We aren't going to enforce these, though, so you'll likely
need to configure your IDE to be less picky.<br>
<br>
-- Kevin<br>
<br>
<o:p></o:p></p>
<div>
<p class="MsoNormal">On 12/4/2023 8:34 AM, Andy Goryachev
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16"">Dear
colleagues:</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16"">Imported
the openjfx project into another workspace with a more
stringent error checking and discovered a few issues:</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""> </span><o:p></o:p></p>
<ol style="margin-top:0in" type="1" start="1">
<li class="MsoListParagraph" style="margin-left:0in;mso-list:l1 level1 lfo3"><span style="font-family:"Iosevka Fixed SS16"">potential
null pointer access: 295</span><o:p></o:p></li>
<li class="MsoListParagraph" style="margin-left:0in;mso-list:l1 level1 lfo3"><span style="font-family:"Iosevka Fixed SS16"">unnecessary
cast or instanceof: 190</span><o:p></o:p></li>
<li class="MsoListParagraph" style="margin-left:0in;mso-list:l1 level1 lfo3"><span style="font-family:"Iosevka Fixed SS16"">redundant
null check: 61</span><o:p></o:p></li>
</ol>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16"">Do
we want to clean these up?</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16"">-andy</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""> </span><o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span style="mso-ligatures:none"><o:p> </o:p></span></p>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>