<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Good point. <br>
<br>
-- Kevin<br>
<br>
<br>
<div class="moz-cite-prefix">On 12/4/2023 9:24 AM, Johan Vos wrote:<br>
</div>
<blockquote type="cite" cite="mid:CABxFH2HU5cASQygg1GYO29z4NXbo49-monCm84TonTNJUb=iaQ@mail.gmail.com">
<div dir="ltr">Also, these commits often affect many files at once
(in scattered locations), and that makes backports harder.
<div><br>
</div>
<div>- Johan</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Dec 4, 2023 at 6:14 PM
Kevin Rushforth <<a href="mailto:kevin.rushforth@oracle.com" moz-do-not-send="true" class="moz-txt-link-freetext">kevin.rushforth@oracle.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div> We did a few of these sort of cleanup fixes a year or so
ago.<br>
<br>
In general, this sort of cleanup *might* be useful, but also
causes some code churn and takes review cycles to ensure
that there is no unintentional side effect.<br>
<br>
The last two might be OK cleanup tasks, but I wouldn't make
them a high priority. Worth noting is that a seemingly
redundant null check or instanceof check is not always a bad
thing, so I wouldn't clean up all of them.<br>
<br>
The first group is the more interesting one. In some cases a
potential null access can highlight actual bugs. However, I
oppose any automated solution for these, since adding a null
check where you don't expect a null (even if you IDE thinks
it might be possible) can hide the root cause of a problem.<br>
<br>
We aren't going to enforce these, though, so you'll likely
need to configure your IDE to be less picky.<br>
<br>
-- Kevin<br>
<br>
<br>
<div>On 12/4/2023 8:34 AM, Andy Goryachev wrote:<br>
</div>
<blockquote type="cite">
<div>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16"">Dear
colleagues:</span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""> </span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16"">Imported
the openjfx project into another workspace with a
more stringent error checking and discovered a few
issues:</span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""> </span></p>
<ul style="margin-top:0in" type="disc">
<li style="margin-left:0in"><span style="font-family:"Iosevka Fixed SS16"">potential
null pointer access: 295</span></li>
<li style="margin-left:0in"><span style="font-family:"Iosevka Fixed SS16"">unnecessary
cast or instanceof: 190</span></li>
<li style="margin-left:0in"><span style="font-family:"Iosevka Fixed SS16"">redundant
null check: 61</span></li>
</ul>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""> </span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16"">Do
we want to clean these up?</span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""> </span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16"">-andy</span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka Fixed SS16""> </span></p>
</div>
</blockquote>
<br>
</div>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>