<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>IMHO, there is no capacity for this.</p>
<p>I did many warning fixes, and there are PR's outstanding with
warning fixes, but they're not getting reviewed.</p>
<p>There are other PR's outstanding that are more valuable, but are
not getting reviewed.</p>
<p>I feel we need to fix that first before we can endulge in warning
fixes.<br>
</p>
<p>As for the potential null pointer access, it's often a false
positive; static analyzers have a hard time determining if a loop
is entered at least once (or an if in that loop) and so will warn
that a local can maybe be null if it was initalized inside a loop.<br>
</p>
<p>--John<br>
</p>
On 04/12/2023 17:34, Andy Goryachev wrote:<br>
<blockquote type="cite"
cite="mid:DM5PR1001MB2172665A727D66F56703E7CCE586A@DM5PR1001MB2172.namprd10.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:"Yu Gothic";
panose-1:2 11 4 0 0 0 0 0 0 0;}@font-face
{font-family:"Iosevka Fixed SS16";
panose-1:2 0 5 9 3 0 0 0 0 4;}@font-face
{font-family:"Times New Roman \(Body CS\)";
panose-1:2 11 6 4 2 2 2 2 2 4;}@font-face
{font-family:"\@Yu Gothic";
panose-1:2 11 4 0 0 0 0 0 0 0;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Iosevka Fixed SS16";
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}div.WordSection1
{page:WordSection1;}ol
{margin-bottom:0in;}ul
{margin-bottom:0in;}</style>
<div class="WordSection1">
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16"">Dear colleagues:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16""><o:p>Â </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16"">Imported the openjfx project into another
workspace with a more stringent error checking and
discovered a few issues:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16""><o:p>Â </o:p></span></p>
<ul style="margin-top:0in" type="disc">
<li class="MsoListParagraph"
style="margin-left:0in;mso-list:l0 level1 lfo1"><span
style="font-family:"Iosevka Fixed SS16"">potential
null pointer access: 295<o:p></o:p></span></li>
<li class="MsoListParagraph"
style="margin-left:0in;mso-list:l0 level1 lfo1"><span
style="font-family:"Iosevka Fixed SS16"">unnecessary
cast or instanceof: 190<o:p></o:p></span></li>
<li class="MsoListParagraph"
style="margin-left:0in;mso-list:l0 level1 lfo1"><span
style="font-family:"Iosevka Fixed SS16"">redundant
null check: 61<o:p></o:p></span></li>
</ul>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16""><o:p>Â </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16"">Do we want to clean these up?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16""><o:p>Â </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16"">-andy<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16""><o:p>Â </o:p></span></p>
</div>
</blockquote>
</body>
</html>