<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>This one for example: <a class="moz-txt-link-freetext" href="https://github.com/openjdk/jfx/pull/1095">https://github.com/openjdk/jfx/pull/1095</a></p>
<p>It was auto closed, and at this point probably has many merge
conflicts, which is why I let it go closed.</p>
<p>--John<br>
</p>
<div class="moz-cite-prefix">On 05/12/2023 20:27, Andy Goryachev
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:DM5PR1001MB2172A67F6B0298C31F175BDDE585A@DM5PR1001MB2172.namprd10.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:"Yu Gothic";
panose-1:2 11 4 0 0 0 0 0 0 0;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}@font-face
{font-family:"Iosevka Fixed SS16";
panose-1:2 0 5 9 3 0 0 0 0 4;}@font-face
{font-family:"Times New Roman \(Body CS\)";
panose-1:2 11 6 4 2 2 2 2 2 4;}@font-face
{font-family:"\@Yu Gothic";
panose-1:2 11 4 0 0 0 0 0 0 0;}@font-face
{font-family:"Iosevka Fixed SS16 ";
panose-1:2 0 5 9 3 0 0 0 0 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Iosevka Fixed SS16";
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}div.WordSection1
{page:WordSection1;}ol
{margin-bottom:0in;}ul
{margin-bottom:0in;}</style>
<div class="WordSection1">
<p><span style="font-family:"Iosevka Fixed SS16"">>
</span>I did many warning fixes, and there are PR's
outstanding with warning fixes, but they're not getting
reviewed.<o:p></o:p></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16"">Are they still in Draft?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16""><a
href="https://github.com/openjdk/jfx/pulls?q=is%3Aopen+is%3Apr+label%3Arfr"
moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/openjdk/jfx/pulls?q=is%3Aopen+is%3Apr+label%3Arfr</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16"">-andy<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Iosevka
Fixed SS16""><o:p> </o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span
style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">openjfx-dev
<a class="moz-txt-link-rfc2396E" href="mailto:openjfx-dev-retn@openjdk.org"><openjfx-dev-retn@openjdk.org></a> on behalf of John
Hendrikx <a class="moz-txt-link-rfc2396E" href="mailto:john.hendrikx@gmail.com"><john.hendrikx@gmail.com></a><br>
<b>Date: </b>Tuesday, December 5, 2023 at 03:16<br>
<b>To: </b><a class="moz-txt-link-abbreviated" href="mailto:openjfx-dev@openjdk.org">openjfx-dev@openjdk.org</a>
<a class="moz-txt-link-rfc2396E" href="mailto:openjfx-dev@openjdk.org"><openjfx-dev@openjdk.org></a><br>
<b>Subject: </b>Re: eclipse warnings</span><span
style="font-size:12.0pt;color:black;mso-ligatures:none"><o:p></o:p></span></p>
</div>
<p>IMHO, there is no capacity for this.<o:p></o:p></p>
<p>I did many warning fixes, and there are PR's outstanding
with warning fixes, but they're not getting reviewed.<o:p></o:p></p>
<p>There are other PR's outstanding that are more valuable,
but are not getting reviewed.<o:p></o:p></p>
<p>I feel we need to fix that first before we can endulge in
warning fixes.<o:p></o:p></p>
<p>As for the potential null pointer access, it's often a
false positive; static analyzers have a hard time
determining if a loop is entered at least once (or an if
in that loop) and so will warn that a local can maybe be
null if it was initalized inside a loop.<o:p></o:p></p>
<p>--John<o:p></o:p></p>
<p class="MsoNormal">On 04/12/2023 17:34, Andy Goryachev
wrote:<br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span
style="font-family:"Iosevka Fixed SS16 "">Dear
colleagues:</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-family:"Iosevka Fixed SS16 ""> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-family:"Iosevka Fixed SS16 "">Imported
the openjfx project into another workspace with a more
stringent error checking and discovered a few issues:</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-family:"Iosevka Fixed SS16 ""> </span><o:p></o:p></p>
<ol style="margin-top:0in" type="1" start="1">
<li class="MsoListParagraph"
style="margin-left:0in;mso-list:l1 level1 lfo3"><span
style="font-family:"Iosevka Fixed SS16"">potential
null pointer access: 295</span><o:p></o:p></li>
<li class="MsoListParagraph"
style="margin-left:0in;mso-list:l1 level1 lfo3"><span
style="font-family:"Iosevka Fixed SS16"">unnecessary
cast or instanceof: 190</span><o:p></o:p></li>
<li class="MsoListParagraph"
style="margin-left:0in;mso-list:l1 level1 lfo3"><span
style="font-family:"Iosevka Fixed SS16"">redundant
null check: 61</span><o:p></o:p></li>
</ol>
<p class="MsoNormal"><span
style="font-family:"Iosevka Fixed SS16 ""> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-family:"Iosevka Fixed SS16 "">Do
we want to clean these up?</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-family:"Iosevka Fixed SS16 ""> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-family:"Iosevka Fixed SS16 "">-andy</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-family:"Iosevka Fixed SS16 ""> </span><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</blockquote>
</body>
</html>