<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Hi Johan,<br>
<br>
I can also try this today, since I have an M1 laptop and have access
to an M2 Mac Mini, both running macOS 14.x.<br>
<br>
-- Kevin<br>
<br>
<br>
<div class="moz-cite-prefix">On 1/11/2024 12:08 AM, Johan Vos wrote:<br>
</div>
<blockquote type="cite" cite="mid:CABxFH2GTiZa7avvpwo4KC70FuzZGnfaK8ri-egmFAVs_hKbefA@mail.gmail.com">
<div dir="ltr">Hi Martin,
<div><br>
</div>
<div>Thanks for testing this. Just to make sure: the fact that
the systemtest pass, is the problem. It shouldn't pass. The
change in PR 1283 caused regression that I didn't notice on
the M2, but I heard the test correctly fails on M1, and I
could confirm it correctly fails on Mac/Intel as well.</div>
<div>Now that I know that this is not just my local M2 setup, I
can have a look at the cause -- thanks for your useful
feedback!</div>
<div><br>
</div>
<div>- Johan</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Jan 10, 2024 at
7:58 PM Martin Fox <<a href="mailto:m_r_fox@sbcglobal.net" moz-do-not-send="true" class="moz-txt-link-freetext">m_r_fox@sbcglobal.net</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>Johan,
<div><br>
</div>
<div>Are you referring to PR 1283? And are you seeing test
failures on Intel or M2?</div>
<div><br>
</div>
<div>I just grabbed PR 1283 and the system test works fine
on my M2 Mac. As for JDK-8089848 I recently looked into
that and it was very specific to changing the focus while
processing windowDidResignKey (though I suppose it could
also happen if you changed focus while processing
windowDidBecomeKey). In that bug I didn’t see any cases
where windowDidBecomeKey wasn’t called, just cases where
it was called on the wrong window. I don’t see any obvious
smoking guns in the SystemMenuBarTest that would lead to
the same condition.</div>
<div><br>
</div>
<div>Martin</div>
<div>
<div><br>
<blockquote type="cite">
<div>On Jan 10, 2024, at 2:10 AM, Johan Vos <<a href="mailto:johan.vos@gluonhq.com" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">johan.vos@gluonhq.com</a>>
wrote:</div>
<br>
<div>
<div dir="ltr">
<div>I noticed different test results when running
systemtests on a mac/intel versus an M2.</div>
<div>when running systemtests from a command line
using </div>
<div><br>
</div>
<div>`sh gradlew --info -PFULL_TEST=true
:systemTests:cleanTest :systemTests:test
--tests=test.com.sun.javafx.tk.quantum.SystemMenuBarTest`</div>
<div><br>
</div>
<div>I traced it down to `windowDidBecomeKey` on
`GlassWindow+Overrides.m` not being called on
the M2. That of course leads to different paths,
hence different test results.</div>
<div><br>
</div>
I wonder if this is somehow related to <a href="https://bugs.openjdk.org/browse/JDK-8089848" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">https://bugs.openjdk.org/browse/JDK-8089848</a>.
Before looking into this, is this something others
observed as well?<br>
<div><br>
</div>
<div>- Johan</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>