<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>I finally found some time to test the latest ea build and can
confirm that it works now on Windows as expected.</p>
<p>Next, I moved to Linux, more specifically Ubuntu 23.04, and
encountered some issues:<br>
- The accent color detection does not work, i.e. it does not
initially detect the value set in the settings and also does not
change when I modify the accent color in the Ubuntu Settings. I
can see some values changing in the map, however the end result is
still the same<br>
- When opening the Ubuntu Settings application, the entire
platform preferences map is updated with weird values but somehow
changes back immediately after. Maybe it reports the default light
mode colors for a split second when opening the settings?<br>
</p>
<p>Once again I do not know whether this is intended or not as there
is no definitive list of which operating systems are supported.
Here is the obligatory preferences map on that system:<br>
</p>
<p><img src="cid:part1.FaWUUswe.NrSZZJu2@xpipe.io"
moz-do-not-send="false"><br>
</p>
<div class="moz-cite-prefix">On 1/30/2024 2:09 PM, Nir Lisker wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CA+0ynh_S6jAZTybEN+KkjP7yKm8nwtVPi0xS3XsxK4GsBvK+bg@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> I'm
under the impression that the last available 22+ea maven
release, which is now almost 3 months old, does not contain
the platform preferences API<br>
</blockquote>
<div><br>
</div>
<div>You are correct, the new API was added a month after the
latest ea build. Versions 11-21 all had at least 1 ea release
per month on average. Not sure why 22 doesn't.</div>
<div><br>
</div>
<div>Johan, do you do these releases or are they part of
OpenJFX?</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Jan 30, 2024 at
2:39 PM Christopher Schnick <<a
href="mailto:crschnick@xpipe.io" target="_blank"
moz-do-not-send="true" class="moz-txt-link-freetext">crschnick@xpipe.io</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Hello Nir,<br>
</p>
<p>I'm not entirely familiar with every ea build, but I'm
under the impression that the last available 22+ea maven
release, which is now almost 3 months old, does not
contain the platform preferences API and also does not
contain the kinda important css performance regression
fixes. <br>
</p>
<div>On 1/30/2024 1:33 PM, Nir Lisker wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi Christopher,
<div><br>
</div>
<div>Looking at Maven Central, <a
href="https://mvnrepository.com/artifact/org.openjfx/javafx"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">https://mvnrepository.com/artifact/org.openjfx/javafx</a>,
JavaFX releases ea builds there, which I sometimes use
myself from Maven/Gradle. Version 21 had 6 ea
versions, and 22 has 3. The release cycle is 6 months
per final version (aligned with OpenJDK).</div>
<div><br>
</div>
<div>- Nir</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Jan 30, 2024
at 2:18 PM Christopher Schnick <<a
href="mailto:crschnick@xpipe.io" target="_blank"
moz-do-not-send="true" class="moz-txt-link-freetext">crschnick@xpipe.io</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Alright I will try out the new ea release once
the fix is integrated. Other than that, everything
works fine for me so far with observing colors
using the platform-specific strings.</p>
<p>As a side note, I think the community would have
caught this issue earlier if there were more
frequent maven releases of ea builds. As of right
now, the only way to properly use recent ea
features is downloading the jars and jmods
manually from the <a href="http://jdk.java.net"
target="_blank" moz-do-not-send="true">jdk.java.net</a>
site, which is cumbersome. I don't know how much
of the maven release pipeline is automated and how
much work more frequent ea releases would be, but
it would definitely help with early testing and
adoption.<br>
</p>
<div>On 1/29/2024 11:09 PM, Michael Strauß wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>I see that the names of the platform
mappings defined in
WinApplication::getPlatformKeyMappings() are
simply wrong
("Windows.UIColor.ForegroundColor" instead of
"Windows.UIColor.Foreground"), so the platform
mappings are not applied to the properties.</div>
<div><br>
</div>
<div>That's quite surprising, and it's a change
that must have slipped into the feature at a
very late stage during development, so that it
went unnoticed by all reviewers.</div>
<div>I'll file a bug and prepare a fix for this
issue.</div>
<div><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Jan
29, 2024 at 10:45 PM Christopher Schnick
<<a href="mailto:crschnick@xpipe.io"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">crschnick@xpipe.io</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Hello Michael,</p>
<p>I took a look at the implementation and
tried to find the issue. From what I can
see, the mappings returned are correct:<br>
<br>
<img
src="cid:part2.ua5PZc0Q.BlSo0zcN@xpipe.io" class=""><br>
<br>
but it seems like they are somehow not
applied the PreferencesProperties:<br>
<br>
<img
src="cid:part3.eA00lJav.lKYdFUPV@xpipe.io" class=""></p>
<p>Let me know whether I can help with
anything to debug this issue.<br>
</p>
<blockquote type="cite">
<blockquote type="cite"> </blockquote>
</blockquote>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
</body>
</html>