<div dir="ltr"><a href="https://github.com/eclipse/buildship/issues/658" target="_blank" style="font-family:"Iosevka Fixed SS16";font-size:14.6667px">https://github.com/eclipse/buildship/issues/658</a> is not that relevant because it describes a problem in Gradle's integration with Eclipse, not with Buildship, but it's reported on Buildship, so I don't think there's much to resolve there except for alignment issues. It has since been solved on Gradle's side. If you go to Preferences > Grade > Experimental features > Enable module support, the described issue will be resolved (and maybe even without it because I'm not sure these features are experimental anymore - Gradle 7 enabled module support by default <a href="https://docs.gradle.org/7.0/release-notes.html#promoted-features">https://docs.gradle.org/7.0/release-notes.html#promoted-features</a>).</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jun 19, 2024 at 3:28 AM Andy Goryachev <<a href="mailto:andy.goryachev@oracle.com">andy.goryachev@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg7354070808055741571">
<div lang="EN-US" style="overflow-wrap: break-word;">
<div class="m_2947694912616579535WordSection1">
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">Thank you Kevin, for this bit of insight. I see the Buildship issue mentioned in one of the comments is still open with no one assigned<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><a href="https://github.com/eclipse/buildship/issues/658" target="_blank">https://github.com/eclipse/buildship/issues/658</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">Chances that it will be fixed in a reasonable time frame are slim to none. I would recommend to make the changes (remove the gradle nature from eclipse config files) in the
meantime, as it allows for clean import of the whole thing into Eclipse.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">Once the situation with Buildship changes, we can remove the Eclipse files altogether and rely on gradle import per JDK-8223374.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">I am also very interested in Nir's view on the subject.
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">-andy<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<div id="m_2947694912616579535mail-editor-reference-message-container">
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal" style="margin-bottom:12pt"><b><span style="font-size:12pt;color:black">From:
</span></b><span style="font-size:12pt;color:black">Kevin Rushforth <<a href="mailto:kevin.rushforth@oracle.com" target="_blank">kevin.rushforth@oracle.com</a>><br>
<b>Date: </b>Tuesday, June 18, 2024 at 16:09<br>
<b>To: </b>Andy Goryachev <<a href="mailto:andy.goryachev@oracle.com" target="_blank">andy.goryachev@oracle.com</a>>, Thiago Milczarek Sayão <<a href="mailto:thiago.sayao@gmail.com" target="_blank">thiago.sayao@gmail.com</a>><br>
<b>Cc: </b><a href="mailto:openjfx-dev@openjdk.org" target="_blank">openjfx-dev@openjdk.org</a> <<a href="mailto:openjfx-dev@openjdk.org" target="_blank">openjfx-dev@openjdk.org</a>><br>
<b>Subject: </b>Re: [External] : Re: Eclipse and Gradle in OpenJFX<u></u><u></u></span></p>
</div>
<p class="MsoNormal" style="margin-bottom:12pt"><span style="font-size:12pt">We also did that for NetBeans, meaning we removed the NetBeans IDE-specific files and use their gradle plug-in (with somewhat mixed results). See
<a href="https://bugs.openjdk.org/browse/JDK-8223375" target="_blank">https://bugs.openjdk.org/browse/JDK-8223375</a><br>
<br>
FWIW, there is an open issue to do the same for Eclipse, but I think it hasn't been looked at in a while. Nir is the assignee so he will likely have some thoughts on this.
<a href="https://bugs.openjdk.org/browse/JDK-8223374" target="_blank">https://bugs.openjdk.org/browse/JDK-8223374</a><br>
<br>
-- Kevin<br>
<br>
<u></u><u></u></span></p>
<div>
<p class="MsoNormal"><span style="font-size:12pt">On 6/18/2024 1:14 PM, Andy Goryachev wrote:<u></u><u></u></span></p>
</div>
<blockquote style="margin-top:5pt;margin-bottom:5pt">
<div>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">Interesting, thank you, Thiago.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">Maybe it's just the quality of gradle support in IntelliJ, or complexity of the Buildship plug-in in Eclipse. It never worked for me, and removing the gradle nature from Eclipse
project files has an added benefit of removing an extra dependency.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">-andy</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<div id="m_2947694912616579535mail-editor-reference-message-container">
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal" style="margin-bottom:12pt"><b><span style="font-size:12pt;color:black">From:
</span></b><span style="font-size:12pt;color:black">Thiago Milczarek Sayão <a href="mailto:thiago.sayao@gmail.com" target="_blank">
<thiago.sayao@gmail.com></a><br>
<b>Date: </b>Tuesday, June 18, 2024 at 12:51<br>
<b>To: </b>Andy Goryachev <a href="mailto:andy.goryachev@oracle.com" target="_blank"><andy.goryachev@oracle.com></a><br>
<b>Cc: </b><a href="mailto:openjfx-dev@openjdk.org" target="_blank">openjfx-dev@openjdk.org</a> <a href="mailto:openjfx-dev@openjdk.org" target="_blank">
<openjfx-dev@openjdk.org></a><br>
<b>Subject: </b>[External] : Re: Eclipse and Gradle in OpenJFX</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt">Andy,</span><u></u><u></u></p>
<div>
<p class="MsoNormal"><span style="font-size:12pt"> </span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt">We kind of did the opposite for Intellij (got rid of the .iml files and went for gradle import):</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt"> </span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt"><a href="https://urldefense.com/v3/__https:/github.com/openjdk/jfx/pull/1009__;!!ACWV5N9M2RV99hQ!KGyKiKF64SpFYCZE7vMq0nzFAyNGv-gTQJoxy9lGH2dg15mO5dl-ZuQha_yGdjFGH_l740roARzs-f231vB1WSlkRk4$" target="_blank">https://github.com/openjdk/jfx/pull/1009</a></span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt"> </span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt">I couldn't get it to detect the manual tests tho. Changing some gradle files worked, but would require a deeper review, so we went without it.</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt"> </span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt">-- Thiago. </span><u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><span style="font-size:12pt"> </span><u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12pt">Em ter., 18 de jun. de 2024 às 16:05, Andy Goryachev <<a href="mailto:andy.goryachev@oracle.com" target="_blank">andy.goryachev@oracle.com</a>> escreveu:</span><u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">Dear developers:</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">Does anyone use gradle in Eclipse (Buildship plug-in) with the OpenJFX repo?</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">The reason I am asking is that in my experience, the gradle nature in OpenJFX is either misconfigured, or obsolete, or both. There is a rather old wiki page [0] which describes
the Eclipse setup, though I don't think it is correct anymore. The initial import of the repository in Eclipse triggers an internal gradle run which creates/modifies a bunch of .classpath and .project files which must be undone before the workspace becomes
usable. In any case, only a proper command line gradle build is supported anyway.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">I would like to propose removing the gradle nature from Eclipse's .project files in OpenJFX. Once done, the projects can be trivially imported into a new workspace with no
extra steps required. This change has no impact on command line build whatsoever.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">What do you think?</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">Thank you</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">-andy</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><b><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">References</span></b><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">[1]
<a href="https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-ConfigureEclipsetousethelatestJDK" target="_blank">
https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-ConfigureEclipsetousethelatestJDK</a></span><u></u><u></u></p>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
<p class="MsoNormal"><span style="font-size:12pt"><u></u> <u></u></span></p>
</div>
</div>
</div>
</div>
</div></blockquote></div>