<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<br>
<blockquote type="cite">
<div>If that is in line with what most people want, I can create a
PR to add this to the CONTRIBUTING.md file.</div>
</blockquote>
<br>
All good from my point of view. That would be great, thank you.<br>
<br>
-- Kevin<br>
<br>
<br>
<div class="moz-cite-prefix">On 7/10/2024 12:25 AM, Johan Vos wrote:<br>
</div>
<blockquote type="cite" cite="mid:CABxFH2Gxm_uU4+=3YeejE0FpTUjshNVT_dy=CAfBVG-7Yvgstw@mail.gmail.com">
<div dir="ltr">Thanks all for commenting.
<div>What I have read so far seems that there is an agreement
for this approach:</div>
<div>* don't prefix tests with `test` anymore</div>
<div>* use a (somehow) descriptive name </div>
<div>* add a comment that refers to the JBS issue that this test
is dealing with</div>
<div>* (optional) in case the test or test scenario is complex,
add a comment that briefly describes what is being tested.</div>
<div><br>
</div>
<div>If that is in line with what most people want, I can create
a PR to add this to the CONTRIBUTING.md file.</div>
<div><br>
</div>
<div>- Johan</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Jul 10, 2024 at
1:36 AM Nir Lisker <<a href="mailto:nlisker@gmail.com" moz-do-not-send="true" class="moz-txt-link-freetext">nlisker@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">*
in some cases, tests are always prefixed with `test` (e.g.
`testFoo()`)<br>
* in some cases, tests have a concise but somehow
meaningful name (e.g. `testScrollBarStaysVisible`)</blockquote>
<div>
<div><br>
</div>
<div>Prefixing 'test' was an old convention for testing
frameworks. I have been dropping that prefix in my
projects since I'm in a test class/package/source folder
anyway, and it's not like there're methods in a test
class that aren't used for testing. I also use long
descriptive names, like
'newValueNotSetIfOldValueWasInvalid()' or,
alternatively, 'doNotSetNewValueIfOldValueWasInvalid()'.
John's nesting names are also good when nesting is
appropriate.</div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">*
in some cases, tests refer to JBS issues (e.g.
testJDK8309935)</blockquote>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">*
in some cases, the test is explained in comments. </blockquote>
<div><br>
</div>
<div>I don't like JBS numbers as names, but I like them as
links in a comment. I prefer the name of the test and
methods to be self-explanatory, like in non-test code,
rather than comments. However, sometimes comments are
needed because of tricky or non-trivial situations,
which is part of what tests are for.</div>
<div><br>
</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Jul 9, 2024 at
6:30 PM Kevin Rushforth <<a href="mailto:kevin.rushforth@oracle.com" target="_blank" moz-do-not-send="true" class="moz-txt-link-freetext">kevin.rushforth@oracle.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div> This might be a combination of Eclipse and eCryptfs.
I agree that 143 chars is very short for a max length.<br>
<br>
-- Kevin<br>
<br>
<br>
<div>On 7/9/2024 8:22 AM, John Hendrikx wrote:<br>
</div>
<blockquote type="cite">
<p><br>
</p>
<div>On 09/07/2024 16:52, Andy Goryachev wrote:<br>
</div>
<blockquote type="cite">
<div><span> </span>
<p class="MsoNormal"><span>Two test files
consistently generate an error in Eclipse</span></p>
<p class="MsoNormal"><span>-
ObservableValueFluentBindingsTest<br>
- LazyObjectBindingTest</span></p>
<p class="MsoNormal"><span> </span></p>
<p class="MsoNormal"><span>I admit I have a weird
setup (EncFS on Linux Mint running on MacBook
Pro), and it only manifests itself in Eclipse
and not in the gradle build - perhaps Eclipse
actually verifies the removal of files?</span></p>
<p class="MsoNormal"><span> </span></p>
<p class="MsoNormal"><span>Anyway, a suggestion -
if you use @Nested, please keep the class
names <i>short</i>.</span></p>
</div>
</blockquote>
<p>This is not an Eclipse bug as I never encounter
such issues. 143 characters is rather short these
days, but I suppose we could limit the nesting a
bit. Still, I'd look into a way to alleviate this
problem in your setup, sooner or later this is going
to be a problem.</p>
<p class="MsoNormal">--John<span style="font-size:12pt"></span></p>
<blockquote type="cite">
<div>
<div id="m_167047913521800652m_-6714775333452006555mail-editor-reference-message-container">
<div>
<div>
<div> </div>
</div>
</div>
</div>
</div>
</blockquote>
</blockquote>
<br>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>