<div dir="ltr">My Eclipse never had this long filename problem, and I reviewed the fluent bindings PR when it was written so I would have seen it. You can try the most basic version of Eclipse (<a href="https://download.eclipse.org/eclipse/downloads/">https://download.eclipse.org/eclipse/downloads/</a>) to see if it still happens if you want to dig into it.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 9, 2024 at 9:09 PM Andy Goryachev <<a href="mailto:andy.goryachev@oracle.com">andy.goryachev@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg-6166743060242180826">
<div lang="EN-US" style="overflow-wrap: break-word;">
<div class="m_-6166743060242180826WordSection1">
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">I wonder what other filesystems do? I just want our code to compile in Eclipse on Linux Mint.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">-andy<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<div id="m_-6166743060242180826mail-editor-reference-message-container">
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal" style="margin-bottom:12pt"><b><span style="font-size:12pt;color:black">From:
</span></b><span style="font-size:12pt;color:black">John Hendrikx <<a href="mailto:john.hendrikx@gmail.com" target="_blank">john.hendrikx@gmail.com</a>><br>
<b>Date: </b>Tuesday, July 9, 2024 at 11:04<br>
<b>To: </b>Andy Goryachev <<a href="mailto:andy.goryachev@oracle.com" target="_blank">andy.goryachev@oracle.com</a>>, Johan Vos <<a href="mailto:johan.vos@gluonhq.com" target="_blank">johan.vos@gluonhq.com</a>>, openjfx-dev <<a href="mailto:openjfx-dev@openjdk.org" target="_blank">openjfx-dev@openjdk.org</a>><br>
<b>Subject: </b>Re: [External] : Re: consistent naming for tests<u></u><u></u></span></p>
</div>
<p>Perhaps, and I guess we're lucky the classes don't fully overlap then... if encfs just cuts off too long names when reading/writing, then as long as the filename is still unique enough that is going to work. As soon as two file names would overlap, they
would overwrite each other and there's no way that the code would still work then.<u></u><u></u></p>
<p>I doubt however this is reasonable to fix in Eclipse; the filesystem is not behaving correctly -- encfs should error out instead of silently truncating too long names.<u></u><u></u></p>
<p>--John<u></u><u></u></p>
<div>
<p class="MsoNormal"><span style="font-size:12pt">On 09/07/2024 19:50, Andy Goryachev wrote:<u></u><u></u></span></p>
</div>
<blockquote style="margin-top:5pt;margin-bottom:5pt">
<div>
<p class="MsoNormal">or gradle may not be verifying that the file is actually deleted.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">Eclipse allows for online replacement (? or whatever that feature is called when it can recompile and replace classes in a running vm), so perhaps it is more diligent when it comes to deleting.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">-andy<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<div id="m_-6166743060242180826mail-editor-reference-message-container">
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal" style="margin-bottom:12pt"><b><span style="font-size:12pt;color:black">From:
</span></b><span style="font-size:12pt;color:black">John Hendrikx <a href="mailto:john.hendrikx@gmail.com" target="_blank">
<john.hendrikx@gmail.com></a><br>
<b>Date: </b>Tuesday, July 9, 2024 at 10:47<br>
<b>To: </b>Andy Goryachev <a href="mailto:andy.goryachev@oracle.com" target="_blank"><andy.goryachev@oracle.com></a>, Johan Vos
<a href="mailto:johan.vos@gluonhq.com" target="_blank"><johan.vos@gluonhq.com></a>, openjfx-dev <a href="mailto:openjfx-dev@openjdk.org" target="_blank">
<openjfx-dev@openjdk.org></a><br>
<b>Subject: </b>Re: [External] : Re: consistent naming for tests</span><u></u><u></u></p>
</div>
<p>Then I can't explain why it doesn't fail on Gradle; it must be generating similar named classes then, but perhaps at a different location (not on encfs) ?.<u></u><u></u></p>
<p>--John<u></u><u></u></p>
<div>
<p class="MsoNormal"><span style="font-size:12pt">On 09/07/2024 19:35, Andy Goryachev wrote:</span><u></u><u></u></p>
</div>
<blockquote style="margin-top:5pt;margin-bottom:5pt">
<div>
<p class="MsoNormal">Anonymous classes are named $1. Nested classes retain their name.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">From the ticket:<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"><a href="https://bugs.openjdk.org/browse/JDK-8334497" target="_blank">https://bugs.openjdk.org/browse/JDK-8334497</a><u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:Arial,sans-serif;color:rgb(23,43,77);background:white">Could not delete: /home/ag/Projects/jfx-2/jfx/rt/modules/javafx.base/testbin/test/javafx/beans/value/ObservableValueFluentBindingsTest$When_flatMap_Called$WithNotNullReturns_ObservableValue_Which$WhenObservedForInvalidations$AndWhenUnobserved.class.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:Arial,sans-serif;color:rgb(23,43,77);background:white"> </span><u></u><u></u></p>
<p class="MsoNormal">-andy<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<div id="m_-6166743060242180826mail-editor-reference-message-container">
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal" style="margin-bottom:12pt"><b><span style="font-size:12pt;color:black">From:
</span></b><span style="font-size:12pt;color:black">John Hendrikx <a href="mailto:john.hendrikx@gmail.com" target="_blank">
<john.hendrikx@gmail.com></a><br>
<b>Date: </b>Tuesday, July 9, 2024 at 10:31<br>
<b>To: </b>Andy Goryachev <a href="mailto:andy.goryachev@oracle.com" target="_blank"><andy.goryachev@oracle.com></a>, Johan Vos
<a href="mailto:johan.vos@gluonhq.com" target="_blank"><johan.vos@gluonhq.com></a>, openjfx-dev <a href="mailto:openjfx-dev@openjdk.org" target="_blank">
<openjfx-dev@openjdk.org></a><br>
<b>Subject: </b>Re: [External] : Re: consistent naming for tests</span><u></u><u></u></p>
</div>
<p>Perhaps it is something Eclipse does differently. Normally nested classed are numbered ($1, $2), so perhaps ecj is compiling these with differently filenames.<u></u><u></u></p>
<p>--John<u></u><u></u></p>
<p>On 09/07/2024 17:37, Andy Goryachev wrote:<u></u><u></u></p>
<blockquote style="margin-top:5pt;margin-bottom:5pt">
<div>
<p class="MsoNormal">Have you tried building in Eclipse on the latest Linux Mint? Or building on an EncFS mount?<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">I don't know why Mint decided to use EncFS knowing its issues, and I suppose I can try fixing my setup (it's a default Mint installation), but I was quite surprised myself and thought that it might be just as easy to fix the tests... here
is how the fix might look:<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"><a href="https://urldefense.com/v3/__https:/github.com/andy-goryachev-oracle/jfx/pull/9__;!!ACWV5N9M2RV99hQ!LaBncRdN0CNaCaX9i-HN9Ahy_JisIzv8qRh2QTWilcD8X42VuKB6KAjQhVsUxYY9XfQoGwBjmYhOucrVx_tv1PGChmrX$" target="_blank">https://github.com/andy-goryachev-oracle/jfx/pull/9</a><u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">-andy<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<div id="m_-6166743060242180826mail-editor-reference-message-container">
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal" style="margin-bottom:12pt"><b><span style="font-size:12pt;color:black">From:
</span></b><span style="font-size:12pt;color:black">John Hendrikx <a href="mailto:john.hendrikx@gmail.com" target="_blank">
<john.hendrikx@gmail.com></a><br>
<b>Date: </b>Tuesday, July 9, 2024 at 08:22<br>
<b>To: </b>Andy Goryachev <a href="mailto:andy.goryachev@oracle.com" target="_blank"><andy.goryachev@oracle.com></a>, Johan Vos
<a href="mailto:johan.vos@gluonhq.com" target="_blank"><johan.vos@gluonhq.com></a>, openjfx-dev <a href="mailto:openjfx-dev@openjdk.org" target="_blank">
<openjfx-dev@openjdk.org></a><br>
<b>Subject: </b>[External] : Re: consistent naming for tests</span><u></u><u></u></p>
</div>
<p> <u></u><u></u></p>
<div>
<p class="MsoNormal"><span style="font-size:12pt">On 09/07/2024 16:52, Andy Goryachev wrote:</span><u></u><u></u></p>
</div>
<blockquote style="margin-top:5pt;margin-bottom:5pt">
<div>
<p class="MsoNormal"><span style="font-size:12pt"> </span><u></u><u></u></p>
<p class="MsoNormal">Two test files consistently generate an error in Eclipse<u></u><u></u></p>
<p class="MsoNormal">- ObservableValueFluentBindingsTest<br>
- LazyObjectBindingTest<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">I admit I have a weird setup (EncFS on Linux Mint running on MacBook Pro), and it only manifests itself in Eclipse and not in the gradle build - perhaps Eclipse actually verifies the removal of files?<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">Anyway, a suggestion - if you use @Nested, please keep the class names
<i>short</i>.<u></u><u></u></p>
</div>
</blockquote>
<p>This is not an Eclipse bug as I never encounter such issues. 143 characters is rather short these days, but I suppose we could limit the nesting a bit. Still, I'd look into a way to alleviate this problem in your setup, sooner or later this is going to
be a problem.<u></u><u></u></p>
<p class="MsoNormal">--John<u></u><u></u></p>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div></blockquote></div>