<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif"><div class="gmail_default" style="font-family:Arial,Helvetica,sans-serif"><font face="verdana, sans-serif">I've a habit of finding non-bugs, so prefer to discuss it first to get some feedback (and/or to avoid duplicating known bugs), but I assume this is definitely an issue, so I created it on JBS now: <span style="color:rgb(51,51,51)">9078765...</span></font></div><div class="gmail_default" style="font-family:Arial,Helvetica,sans-serif"><span style="color:rgb(51,51,51)"><font face="verdana, sans-serif"><br></font></span></div><div class="gmail_default" style="font-family:Arial,Helvetica,sans-serif"><span style="color:rgb(51,51,51)"><font face="verdana, sans-serif">Unfortunately one cannot attach screenshots on JBS submissions, so a text description will have to do.</font></span></div><div class="gmail_default" style="font-family:Arial,Helvetica,sans-serif"><span style="color:rgb(51,51,51)"><font face="verdana, sans-serif"><br></font></span></div><div class="gmail_default" style="font-family:Arial,Helvetica,sans-serif"><span style="color:rgb(51,51,51)"><font face="verdana, sans-serif">Thanks!</font></span></div><div class="gmail_default" style="font-family:Arial,Helvetica,sans-serif"><span style="color:rgb(51,51,51)"><font face="verdana, sans-serif"><br></font></span></div><div class="gmail_default" style="font-family:Arial,Helvetica,sans-serif"><span style="color:rgb(51,51,51)"><font face="verdana, sans-serif"><br></font></span></div><div class="gmail_default" style="font-family:Arial,Helvetica,sans-serif"><span style="color:rgb(51,51,51)"><font face="verdana, sans-serif">Kind Regards,</font></span></div><div class="gmail_default" style="font-family:Arial,Helvetica,sans-serif"><span style="color:rgb(51,51,51)"><font face="verdana, sans-serif">Cormac</font></span></div></div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Wed, 23 Jul 2025 at 20:30, Andy Goryachev <<a href="mailto:andy.goryachev@oracle.com">andy.goryachev@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg-3437256279771531913">
<div lang="EN-US" style="overflow-wrap: break-word;">
<div class="m_-3437256279771531913WordSection1">
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">Do we have the JBS ticket filed for this issue?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16"">-andy<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:"Iosevka Fixed SS16""><u></u> <u></u></span></p>
<div id="m_-3437256279771531913mail-editor-reference-message-container">
<div>
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal" style="margin-bottom:12pt"><b><span style="font-size:12pt;color:black">From:
</span></b><span style="font-size:12pt;color:black">openjfx-dev <<a href="mailto:openjfx-dev-retn@openjdk.org" target="_blank">openjfx-dev-retn@openjdk.org</a>> on behalf of Cormac Redmond <<a href="mailto:credmond@certak.com" target="_blank">credmond@certak.com</a>><br>
<b>Date: </b>Tuesday, July 22, 2025 at 12:08<br>
<b>To: </b><a href="mailto:openjfx-dev@openjdk.org" target="_blank">openjfx-dev@openjdk.org</a> <<a href="mailto:openjfx-dev@openjdk.org" target="_blank">openjfx-dev@openjdk.org</a>><br>
<b>Subject: </b>Re: Bug: ToolBar always using overflow menu whenever a scaled resolution set<u></u><u></u></span></p>
</div>
<p>Any thoughts on this? It seems like a definite JavaFX bug with hopefully a simple fix. Choosing any fractional scaled resolution may or may not cause the issue. I also wonder what other controls may suffer from the same issues.<u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:12pt"><u></u> <u></u></span></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12pt">On Sat 19 Jul 2025, 19:01 Cormac Redmond, <<a href="mailto:credmond@certak.com" target="_blank">credmond@certak.com</a>> wrote:<u></u><u></u></span></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif">Hi,<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif">I've traced the bug down to a rounding error. See the below screenshot in ToolBarSkin's getOverflowNodeIndex(double length).<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif">These two numbers are not equal, but should be. snapSizeX() ultimately ends up grabbing getSnapScaleX(), whose value would be 1.25. If it's 1 (i.e., no scaling), we don't see
this issue. If it's 1.25, we see this rounding difference between the two numbers in this instance. If these two numbers are not equal, the calling code mistakenly assumes the overflow box is necessary.<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><img border="0" width="562" height="304" style="width: 5.8541in; height: 3.1666in;" id="m_-3437256279771531913_x0000_i1029" src="cid:ii_198395d1bb1cb971f165"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif">Can someone fix this?<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif">Kind Regards,<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif">Cormac<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><span style="font-size:12pt"><u></u> <u></u></span></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12pt">On Sat, 19 Jul 2025 at 18:33, Cormac Redmond <<a href="mailto:credmond@certak.com" target="_blank">credmond@certak.com</a>> wrote:<u></u><u></u></span></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif">Confusingly, make the string longer, such as "Create Schema 123 123 123":<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"> bp.setTop(new HBox(new ToolBar(new Button("Create Schema 123 123 123"))));<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif">...and the overflow doesn't appear (but still, anything between and including 13-24, it does):<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><img border="0" width="562" height="187" style="width: 5.8541in; height: 1.9479in;" id="m_-3437256279771531913_x0000_i1028" src="cid:ii_198395d1bb1cb971f164"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif">Kind Regards,<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif">Cormac<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><span style="font-size:12pt"><u></u> <u></u></span></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12pt">On Sat, 19 Jul 2025 at 11:12, Cormac Redmond <<a href="mailto:credmond@certak.com" target="_blank">credmond@certak.com</a>> wrote:<u></u><u></u></span></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:black">Hi,</span><span style="font-size:12pt;color:black"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;color:black"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:black">There's a bug whenever using a ToolBar on Windows if you set your resolution scale > 100% (which is quite common). E.g., 125%:</span><span style="font-size:12pt;color:black"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;color:black"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:black"><img border="0" width="562" height="59" style="width: 5.8541in; height: 0.6145in;" id="m_-3437256279771531913_x0000_i1027" src="cid:ii_198395d1bb1cb971f161"></span><span style="font-size:12pt;color:black"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;color:black"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:rgb(34,34,34)">E.g., this is what a ToolBar always renders if scale is 125%:</span><span style="font-size:12pt;color:black"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;color:black"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:black"><img border="0" width="562" height="375" style="width: 5.8541in; height: 3.9062in;" id="m_-3437256279771531913_x0000_i1026" src="cid:ii_198395d1bb1cb971f162"></span><span style="font-size:12pt;color:black"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;color:black"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:rgb(34,34,34)">As compared to what you'd expect (scale set to normal/100%):</span><span style="font-size:12pt;color:black"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;color:black"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:black"><img border="0" width="562" height="375" style="width: 5.8541in; height: 3.9062in;" id="m_-3437256279771531913_x0000_i1025" src="cid:ii_198395d1bb1cb971f163"></span><span style="font-size:12pt;color:black"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;color:black"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:rgb(34,34,34)">Very easy to reproduce the above, set your scale to 125% and run this:</span><span style="font-size:12pt;color:black"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;color:black"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:rgb(34,34,34)">public class ToolbarBugApp extends Application {</span><span style="font-size:12pt;color:black"><u></u><u></u></span></p>
</div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif"><br>
@Override<br>
public void start(Stage primaryStage) {<br>
BorderPane bp = new BorderPane();<br>
// Wrapping in HBox and using button with 13+ chars c<span class="m_-3437256279771531913gmaildefault"><span style="color:black">auses </span></span>bug<br>
bp.setTop(new HBox(new ToolBar(new Button("Create Schema")))); // BUG<br>
// bp.setTop(new ToolBar(new Button("Create Schema"))); // NO BUG<span class="m_-3437256279771531913gmaildefault"><span style="color:black"> (no HBox)</span></span><br>
// bp.setTop(new HBox(new ToolBar(new Button("Create Schem")))); // NO BUG<span class="m_-3437256279771531913gmaildefault"><span style="color:black"> (12 chars)</span></span><br>
primaryStage.setScene(new Scene(bp, 600, 400));<br>
primaryStage.show();<br>
}<br>
<br>
public static void main(String[] args) {<br>
launch(args);<br>
}<br>
}<br clear="all">
</span><span style="font-size:12pt"><u></u><u></u></span></p>
</div>
<div>
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12pt"><u></u> <u></u></span></p>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:rgb(34,34,34)">As per the comments, this bug appears to happen when your ToolBar is wrapped in a HBox and contains a Button that has 13+ characters, for example. This is quite
a serious bug, in my opinion.</span><span style="font-size:12pt;color:black"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;color:black"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:rgb(34,34,34)">I believe this is present in JFX 24 and the JFX 25 master branch.</span><span style="font-size:12pt;color:black"><u></u><u></u></span></p>
</div>
<p class="MsoNormal"><span style="font-size:12pt"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span class="m_-3437256279771531913gmaildefault"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:black">Kind </span></span><span style="font-size:12pt;font-family:Verdana,sans-serif;color:black">Regards,</span><span style="font-size:12pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt"><u></u> <u></u></span></p>
</div>
<p class="MsoNormal"><b><span style="font-size:12pt;font-family:Verdana,sans-serif;color:black">Cormac Redmond</span></b><span style="font-size:12pt"><u></u><u></u></span></p>
<div>
<p class="MsoNormal"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:black">Software Engineer, Certak Ltd.</span><span style="font-size:12pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:Verdana,sans-serif">e: <a href="mailto:credmond@certak.com" target="_blank">
credmond@certak.com</a> | m: +353 (0) 86 268 2152 | w: <a href="http://www.certak.com" target="_blank">
www.certak.com</a></span><span style="font-size:12pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12pt"><u></u> <u></u></span></p>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</div></blockquote></div>