VectorBox enabling

[Vladimir Ivanov]

Another thing I was curious about is delayed inlining of vector ops:

+      } else if (should_delay_vector_inlining(callee, jvms)) {
+        assert(!delayed_forbidden, "delay should be allowed");
+        return CallGenerator::for_late_inline(callee, cg);

+bool Compile::should_delay_vector_inlining(ciMethod* call_method, 
JVMState* jvms) {
+  return call_method->is_vector_method();
+}

Can you elaborate, please, when does it help?

Best regards,
Vladimir Ivanov

On 11/15/17 4:37 AM, Lupusoru, Razvan A wrote:
> Hi everyone,
> 
> VectorBox enabling is now mostly complete and appearing to be functional. The VectorBox supports being able to generate objects for all supported Vector objects that have some intrinsic method. This includes GenericMask (subject to some limitation noted below). Additionally, VectorBox nodes can be removed along with their allocations in cases when the objects do not need created. I have tested BLAS (saxpy, sdot) and Sepia demo used in JavaOne and performance has not regressed.
> 
> Please see attached patch and if there are no concerns, I will merge tomorrow.
> http://cr.openjdk.java.net/~rlupusoru/panama/webrev_vectorbox_04/
> 
> Note that in patch you will find some "FIXME" related to masks (namely mask shape and type recovery is not possible at times during intrinsification). After this patch, I will look into solving this problem by potentially having specialized masks for each type and shape combination (as is done for species).
> 
> The main limitations remaining with VectorBox are as follows:
> 
> -          If VectorBox is used by any non-intrinsified calls, stores to heap, or runtime calls via deopt, it will generate an object at the original call site. The plan is to move this to slow path when Vector API object identities can be ignored.
> 
> -          VectorBox for GenericMask does not set the Species field. This will either be fixed in a follow-up patch or the approach for specialized masks will be employed instead.
> 
> Thanks so much!
> 
> --Razvan
>