RFR 81928080 Remove RuntimeSupport and refactor, move Transformer to internal package
Henry Jen
henry.jen at oracle.com
Thu Nov 30 18:37:26 UTC 2017
Looks good, I like Transformer function into Scope. Note that BindingRegistry is internal, but Transformer is public. Idea was that transform function is exposed to user and providing only limited access to BindingRegistry. The move would hide the transform function of N2J and J2N.
Cheers,
Henry
> On Nov 30, 2017, at 5:05 AM, Maurizio Cimadamore <maurizio.cimadamore at oracle.com> wrote:
>
> Looks good
>
> Maurizio
>
>
> On 30/11/17 13:00, Sundararajan Athijegannathan wrote:
>> Updated: http://cr.openjdk.java.net/~sundar/8192808/webrev.01/
>>
>> Only change w.r.t webrev.00 is to remove code from Transformer to BindingRegister and remove Transformer class.
>>
>> Please review.
>>
>> -Sundar
>>
>> On 30/11/17, 5:10 PM, Maurizio Cimadamore wrote:
>>> Looks great - would it make sense to consolidate Transformer into BindingRegistry (maybe as part of a followup fix?)
>>>
>>> Maurizio
>>>
>>>
>>> On 30/11/17 11:46, Sundararajan Athijegannathan wrote:
>>>> Please review http://cr.openjdk.java.net/~sundar/8192808/webrev.00/
>>>>
>>>> Moving java.nicl.types.Transformer to jdk.internal.nicl.types.Transformer. Removing java.nicl.RuntimeSupport. The public utility methods methods useful for application have been moved to java.nicl.Scope and java.nicl.Pointer.
>>>>
>>>> Thanks,
>>>> -Sundar
>>>
>
More information about the panama-dev
mailing list