VectorAPI abs intrinsic for Byte,Short and Long

[Halimi, Jean-Philippe]

Hi Paul,

Both variants should be OK. If you look at line 1312, the case size_in_bits > 128 is already handled.

Let me know if there's anything else. :-)

Thanks,

Jp

-----Original Message-----
From: Paul Sandoz [mailto:paul.sandoz at oracle.com] 
Sent: Monday, April 16, 2018 10:38 AM
To: Halimi, Jean-Philippe <jean-philippe.halimi at intel.com>
Cc: panama-dev at openjdk.java.net
Subject: Re: VectorAPI abs intrinsic for Byte,Short and Long

Excuse my ignorance:

src/hotspot/cpu/x86/x86.ad
--

1321 if (is_integral_type(bt) && size_in_bits == 256 && UseAVX < 2) { ret_value = false; }

Should that be:

  size_in_bits > 128

?

Paul.

> On Apr 16, 2018, at 10:13 AM, Halimi, Jean-Philippe <jean-philippe.halimi at intel.com> wrote:
> 
> Hi all,
> 
> I would like to share a patch adding support for abs intrinsic for byte, short and long types in VectorAPI.
> 
> Could you please review the patch here:
> http://cr.openjdk.java.net/~jphalimi/webrev_abs_byte_short_long_v1.0/var/www/html/tmp/webrev_abs_byte_short_long_v1.0/
> 
> Thank you,
> 
> Jp