[foreign] RFR 8215486: Check for no arrays in header functions broken after SystemABI refactoring

[Jorn Vernee]

Thanks for figuring this out!

I've applied the same check in the Windows ABI implementation, which 
gets the test passing again.

Jorn

Maurizio Cimadamore schreef op 2018-12-17 15:12:
> Hi,
> this issue has been discovered by Jorn (thanks!) when working on
> Windows port. A bug has been introduced after the SystemABI work: not
> all upcall handlers/invokers check for absence of arrays in native
> function signatures.
> 
> The fix is to move the check closer to SysVABI::upcall/downcall entry
> points, so that it will be ran no matter the concrete invoker/upcall
> handler being used.
> 
> I've also added another run to an existing test (ArrayInFunctionsTest)
> to make sure it's run with both invokers.
> 
> Webrev:
> https://cr.openjdk.java.net/~mcimadamore/panama/8215486/
> 
> Cheers
> Maurizio