[vector] Unary/Ternary ops

[Lupusoru, Razvan A]

Agreed with Paul. Other than that it looks good to me.

Two comments:
- You mentioned a change on os linux to quiet down clang but I do not see it as part of your change
- The integral types also have the comments " // Unary Operations" and "// Ternary Operations" but no methods defined yet. Maybe those should also be conditionally generated.

--Razvan 

-----Original Message-----
From: panama-dev [mailto:panama-dev-bounces at openjdk.java.net] On Behalf Of Paul Sandoz
Sent: Wednesday, February 14, 2018 10:27 AM
To: Al K <someusername3 at gmail.com>
Cc: panama-dev at openjdk.java.net
Subject: Re: [vector] Unary/Ternary ops



> On Feb 14, 2018, at 10:12 AM, Al K <someusername3 at gmail.com> wrote:
> 
> Oops, wrong patch link, see
> http://cr.openjdk.java.net/~vlivanov/panama/al_miftah/vector_ops/webrev.00/index.html
> 

One comment:

- For fma I recommend creating a package private TriFunction rather than packing into an array, then i think the additional casts will be redundant.

Thanks, 
Paul.

> On Wed, Feb 14, 2018 at 11:54 AM, Al K <someusername3 at gmail.com> wrote:
> 
>> http://cr.openjdk.java.net/~vlivanov/panama/vector.generalized_intrinsics/webrev.06/
>> 
>> 
>> This extends the generalized intrinsics changeset with the following:
>> 
>> 1. General ternary ops - currently only fma
>> 
>> 2. General unary ops - abs/neg/sqrt
>> 
>> 
>> I've replaced the previous inline_vector_binary_operation() in opto/library_call
>> 
>> with a generic inline_vector_nary_operation() to avoid writing specialized impls
>> 
>> for the various n-ary ops.
>> 
>> 
>> There's also a change in os/linux/os_linux to fix the pointer comparison so clang
>> 
>> would stop complaining.
>> 
>> 
>> I've signed the OCA, awaiting for it to be reflected on the site.
>> 
>> 
>> Cheers,
>> 
>> Al
>> 
>>