[nicl] Adding ToolProvider implementation for jextract and a simple test for jextract tool

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Thu Feb 22 16:04:59 UTC 2018


Looks good

Maurizio


On 22/02/18 15:37, Sundararajan Athijegannathan wrote:
> Thanks. Updated: 
> http://cr.openjdk.java.net/~sundar/jextract_tool_provider_and_test/webrev.01/
>
> -Sundar
>
> On 22/02/18, 8:47 PM, Maurizio Cimadamore wrote:
>> Looks good,
>> minor nit: you might want to use err/out from the Context instance 
>> inside Tool::main instead of duplicating the streams.
>>
>> Maurizio
>>
>>
>>
>> On 22/02/18 14:27, Sundararajan Athijegannathan wrote:
>>> Please review: 
>>> http://cr.openjdk.java.net/~sundar/jextract_tool_provider_and_test/webrev.00/
>>>
>>> Thanks,
>>> -Sundar
>>



More information about the panama-dev mailing list