[nicl] Adding --exclude-symbols option to jextract tool
Maurizio Cimadamore
maurizio.cimadamore at oracle.com
Tue Feb 27 11:04:48 UTC 2018
This looks good - few comments:
* would it make sense to have, in addition to exclude-symbols, also an
include-symbols?
* I think Predicate<String> works just as well - you don't really need
the SymbolFilter interface (a similar argument could also apply to
SymbolChecker).
* Since there's a lot of shared stuff between Context and HeaderFile,
and given that HeaderFile takes in a Context object anyway - how about
accessing checker and filters directly from the context, instead of
passing them as constructor arguments?
Cheers
Maurizio
On 26/02/18 15:55, Sundararajan Athijegannathan wrote:
> Please review
> http://cr.openjdk.java.net/~sundar/jextract_exclude_symbols/webrev.00/
>
> By default jextract generates interface that includes all the native
> declarations in the input header files. --exclude-symbol option can be
> used to filter native symbols in the input header files.
>
> Thanks,
> -Sundar
More information about the panama-dev
mailing list