RFR 8188226: jextract diagnostic generation should be improved

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Tue Jan 9 10:49:57 UTC 2018


Looks good. Few questions:

* is the copyright date correct? Or should it be 2016, 2018 ?
* why the different code to access system properties e.g. 
Boolean.getBoolean (in Main) vs. PrivilegedAction (in LibClang) ?

Maurizio


On 08/01/18 16:39, Sundararajan Athijegannathan wrote:
> Please review: http://cr.openjdk.java.net/~sundar/8188226/webrev.00/
>
> * stack traces printed only on "debug" [when jextract.debug property 
> is set]
> * default log level set to "warning" [user can change log level by 
> -log option already]
> * added resource for localizing messages.
>
> PS. Piggybacking to add missing copyright messages in few source files.
>
> Thanks,
> -Sundar



More information about the panama-dev mailing list