RFR 8188226: jextract diagnostic generation should be improved

[Maurizio Cimadamore]

Webrev looks good, thanks for following up

Maurizio


On 10/01/18 10:20, Sundararajan Athijegannathan wrote:
> jdk.internal.clang is to be used only by a tool (jextract) and not 
> export any API for arbitrary code. The module info of 
> jdk.internal.clang exports its sole package only to jdk.jextract 
> module. So it is effectively part of jdk.jextract and not a reusable 
> module/library.
>
> Thanks,
> -Sundar
>
> On 10/01/18, 9:59 AM, Henry Jen wrote:
>> I am not sure if we want to remove it, after all LibClang is a 
>> library. But I will leave to your judgement on whether this is 
>> necessary.
>>
>> Cheers,
>> Henry
>>
>>
>>> On Jan 9, 2018, at 7:22 PM, Sundararajan 
>>> Athijegannathan<sundararajan.athijegannathan at oracle.com>  wrote:
>>>
>>> Hi Henry, Maurizio,
>>>
>>> Yes, Henry is right! My mistake. Removed doPrivileged in LibClang.java
>>>
>>> Updated webrev: http://cr.openjdk.java.net/~sundar/8188226/webrev.01/
>>>
>>> Thanks,
>>> -Sundar
>>>
>>> On 10/01/18, 1:08 AM, Henry Jen wrote:
>>>>> On Jan 9, 2018, at 10:03 AM, Maurizio 
>>>>> Cimadamore<maurizio.cimadamore at oracle.com>   wrote:
>>>>>
>>>>>
>>>>>
>>>>> On 09/01/18 15:17, Sundararajan Athijegannathan wrote:
>>>>>> On 09/01/18, 4:19 PM, Maurizio Cimadamore wrote:
>>>>>>> Looks good. Few questions:
>>>>>>>
>>>>>>> * is the copyright date correct? Or should it be 2016, 2018 ?
>>>>>> If I didn't touch the code to make any other change (other than 
>>>>>> copyright), I added 2016 (which I presume is the original date 
>>>>>> for those files).
>>>>> Ok
>>>>>>> * why the different code to access system properties e.g. 
>>>>>>> Boolean.getBoolean (in Main) vs. PrivilegedAction (in LibClang) ?
>>>>>>>
>>>>>> Tools like jextract won't be run with security manager on. 
>>>>>> LibClang is used by jextract generated code + user code at 
>>>>>> runtime - we need to read property under doPrivileged there.
>>>>> Aha - thanks for th clarification.
>>>>>
>>>> Just to clarify, LibClang is not used by generated code, LibClang 
>>>> is only for jextract at build-time.
>>>>
>>>> Cheers,
>>>> Henry
>>>>
>>>>> Good to go!
>>>>>
>>>>> Maurizio
>>>>>> Thanks
>>>>>> -Sundar
>>>>>>
>>>>>>> Maurizio
>>>>>>>
>>>>>>>
>>>>>>> On 08/01/18 16:39, Sundararajan Athijegannathan wrote:
>>>>>>>> Please review: 
>>>>>>>> http://cr.openjdk.java.net/~sundar/8188226/webrev.00/
>>>>>>>>
>>>>>>>> * stack traces printed only on "debug" [when jextract.debug 
>>>>>>>> property is set]
>>>>>>>> * default log level set to "warning" [user can change log level 
>>>>>>>> by -log option already]
>>>>>>>> * added resource for localizing messages.
>>>>>>>>
>>>>>>>> PS. Piggybacking to add missing copyright messages in few 
>>>>>>>> source files.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> -Sundar