[foreign] RFR 8206983: jextract generates illegal class for header with duplicate declarations

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Tue Jul 10 12:44:51 UTC 2018


Looks good.

Note that the

if (! set.contains( ... ) ) {
     return;
}
set.add(...)
<rest of logic>

can be simplified to this:

if (!set.add(...)) {
    return;
}
<rest of logic>


Maurizio


On 10/07/18 13:32, Sundararajan Athijegannathan wrote:
> Please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8206983
> Webrev: http://cr.openjdk.java.net/~sundar/8206983/webrev.00/
>
> Thanks,
> -Sundar
>



More information about the panama-dev mailing list