[jextract] RFR 8207781: Add a jextract, binder test for libproc library on Mac

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Thu Jul 19 04:57:19 UTC 2018


Hi,

Thanks for your review. I was worried about test stability and so 
avoided checking output from libproc. But you're right - we could 
minimally check about the current process. Added to check that the 
current process pid is listed.  I'm going ahead with the push.

Updated webrev for the record: 
http://cr.openjdk.java.net/~sundar/8207781/webrev.01/

thanks,
-Sundar

On 19/07/18, 2:52 AM, Henry Jen wrote:
> I didn’t run the test, but seems reasonable to me. It’s a good exercise to jextract and binder.
>
> It would be great if we have something to validate with, perhaps the jtreg instance for running the test? But nonetheless, the webrev is good to me.
>
> Cheers,
> Henry
>
>
>> On Jul 18, 2018, at 9:28 AM, Sundararajan Athijegannathan<sundararajan.athijegannathan at oracle.com>  wrote:
>>
>> Please review.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8207781
>> Webrev: http://cr.openjdk.java.net/~sundar/8207781/webrev.00/
>>
>> Thanks,
>> -Sundar


More information about the panama-dev mailing list