RFR 8207351 jextract should generate properties file containing meta info under META-INF

[Henry Jen]

It’s an improvement. I think it’s OK to push the code as work in progress, after revert the change on Context::writeJar, as the added args parameter is not used, at least for now.

It’s unclear to me how we going to read back this jextract.properties, and how to make use of it. So I am still a little uncomfortable of the injection of args. As if we treat that as a single value, we won’t be able to do much about it. On the other hand, if we want to make sense out it, we should pass that value to it’s origin, i.e Main, to make sense out of it, that lead us back to my origin concern regarding messy boundaries.

There are ways to clean this up, but really depends on how we gonna read back make use of the saved metadata.

Cheers,
Henry


> On Jul 20, 2018, at 5:06 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
> 
> Hi,
> 
> Thanks Henry. I've moved args back to main and passing it to Context only when calling collectXYZ methods. Also meta-info writing moved to collectJarFile(JarOutputStream, …) as suggested.
> 
> Updated review: http://cr.openjdk.java.net/~sundar/8207351/webrev.01/
> 
> PS. Response to this email -> http://mail.openjdk.java.net/pipermail/panama-dev/2018-July/002358.html
> 
> Thanks,
> -Sundar