math routine implementation with .s files

[Lupusoru, Razvan A]

Interesting trick. One concern that I have is that the C preprocessor is not used for .s for every architecture. In Linux, assembler is typically a compiler flag and preprocessor also is run before assembling. But, for Windows, a separate assembler with incompatible preprocessor syntax exists. And the makefile changes to support running C preprocessor and also the assembler make it quite complicated (and I am already having a hard time enabling the Windows .s file build because of the incompatible assembler).

Rahul is working on the renaming scheme right now but I am not sure combining them is productive due to difficulty in getting it right and potential bugs we may introduce, plus increased burden to filter out steps in future if any files need updating. Would you be okay if we just rename the files but leave them separated? Thanks!

--Razvan

-----Original Message-----
From: panama-dev [mailto:panama-dev-bounces at openjdk.java.net] On Behalf Of John Rose
Sent: Monday, June 04, 2018 2:00 PM
To: Kandu, Rahul <rahul.kandu at intel.com>
Cc: panama-dev at openjdk.java.net
Subject: Re: math routine implementation with .s files

On Jun 4, 2018, at 1:48 PM, John Rose <john.r.rose at oracle.com> wrote:
> 
> # +++ adjustments for conflicting identifiers #define B1 
> FILE_SCOPE(B1) #define L2 FILE_SCOPE(L2) #define FILE_SCOPE(x) 
> x##_##FILE_SCOPE_NAME # +++ scope file1.s

My cpp-ology is slipping.  That should be:

#define B1 FILE_SCOPE(B1)
#define L2 FILE_SCOPE(L2)
#define FILE_SCOPE(x) FILE_SCOPE1(x,FILE_SCOPE_NAME) #define FILE_SCOPE1(x,n) FILE_SCOPE2(x,n) #define FILE_SCOPE2(x,n) x##_##n