RFR: jextract to spit Array for array type and function layout for callbacks
Maurizio Cimadamore
maurizio.cimadamore at oracle.com
Wed Jun 13 15:30:55 UTC 2018
Looks good - thanks for splitting the types
Maurizio
On 12/06/18 18:15, Henry Jen wrote:
> Updated webrev[1] in which I separate array into JType.ArrayType as rename of JType.Array
>
> [1] http://cr.openjdk.java.net/~henryjen/panama/foreign/jextract_array/1/webrev/
>
> Cheers,
> Henry
>
>
>
>> On Jun 12, 2018, at 5:39 AM, Maurizio Cimadamore <maurizio.cimadamore at oracle.com> wrote:
>>
>> Also, if the old JType.Array is meant to be unused, let's remove it.
>>
>> Maurizio
>>
>>
>> On 12/06/18 13:38, Maurizio Cimadamore wrote:
>>> Looks good, but I'd prefer to have a separate ArrayType for describing the array carrier, rather than reusing pointer for both.
>>>
>>> Maurizio
>>>
>>>
>>> On 12/06/18 07:09, Henry Jen wrote:
>>>> Hi,
>>>>
>>>> Please review the webrev[1] that will,
>>>>
>>>> - generate Array as carrier type for array instead of java array or Pointer
>>>> - make sure NativeCallback functional interface has a function instead of a pointer to function as layout
>>>>
>>>> Cheers,
>>>> Henry
>>>>
>>>> [1] http://cr.openjdk.java.net/~henryjen/panama/foreign/jextract_array/webrev/
More information about the panama-dev
mailing list