[VectorAPI] Shift operations test coverage

[Halimi, Jean-Philippe]

Hi Paul,

Apologies for the late reply. It took me a while to solve a couple of technical issues related to the new operations. Here is the updated webrev:

http://cr.openjdk.java.net/~jphalimi/webrev_shiftTests_v1.1/webrev/

I had to modify the VectorAPI java code since there was a typo for aShiftR operation with a vector.

Please let me know your thoughts,

Jp

-----Original Message-----
From: Paul Sandoz [mailto:paul.sandoz at oracle.com] 
Sent: Thursday, June 7, 2018 12:03 PM
To: Halimi, Jean-Philippe <jean-philippe.halimi at intel.com>
Cc: panama-dev at openjdk.java.net
Subject: Re: [VectorAPI] Shift operations test coverage



> On Jun 7, 2018, at 11:47 AM, Halimi, Jean-Philippe <jean-philippe.halimi at intel.com> wrote:
> 
> Thanks for your review.
> 
> I will add the missing template file. However, I cannot find the operations you are referring to in the java source files.
> 
> Namely, here is what I see:
> 

Perhaps because some of the mask accepting operations have not yet been pushed down into the concrete vector types and implemented using blend?

> shiftL(int)

http://hg.openjdk.java.net/panama/dev/file/20033289f414/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntVector.java#l578

> shiftR(int)

http://hg.openjdk.java.net/panama/dev/file/20033289f414/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntVector.java#l637

> aShiftR(int)

http://hg.openjdk.java.net/panama/dev/file/20033289f414/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntVector.java#l696


> shiftL(vec) shiftL(vec, mask)
> shiftR(vec) shiftR(vec, mask)
> 

ashiftR(vec) ashiftR(vec, mask)

http://hg.openjdk.java.net/panama/dev/file/20033289f414/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntVector.java#l711

Paul.

> Did I miss something?
> 
> Jp
> 
> -----Original Message-----
> From: Paul Sandoz [mailto:paul.sandoz at oracle.com] 
> Sent: Tuesday, June 5, 2018 3:40 PM
> To: Halimi, Jean-Philippe <jean-philippe.halimi at intel.com>
> Cc: panama-dev at openjdk.java.net
> Subject: Re: [VectorAPI] Shift operations test coverage
> 
> Some stuff is missing:
> 
> - Shift-op.template
> 
> - tests for arithmetic shift right with a vector (with and without a mask)
> 
> - tests for shifting by a constant and a mask
> 
> Paul.
> 
>> On Jun 5, 2018, at 1:09 PM, Halimi, Jean-Philippe <jean-philippe.halimi at intel.com> wrote:
>> 
>> Dear all,
>> 
>> I have added support for Shift operations test coverage in the VectorAPI test infrastructure.
>> 
>> Here is the webrev:
>> http://cr.openjdk.java.net/~jphalimi/webrev_shiftTests_v1.0/
>> 
>> Please let me know your thoughts! :)
>> 
>> Jp
>