[foreign] RFR Bounded Pointer, MemoryRegion bounds checks

Henry Jen henry.jen at oracle.com
Fri Jun 22 05:59:06 UTC 2018


Looks good to me. Nitpick, you don’t seem to need the scope in the test.

Cheers,
Henry


> On Jun 21, 2018, at 5:56 PM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
> 
> 
> Please review: http://cr.openjdk.java.net/~sundar/memory_region_bound_checks/webrev.00/
> 
> Piggybacking to remove 'errno' test in StdLibTest.java As (privately) discussed with Maurizio Cimadamore, Henry Jen and Mikael Vidstedt, errno test is broken/wrong. Apart from multithreading issues (we need to call int* errno() and not access errno global var), errno checking in Java code won't work without JVM changes to facilitate that. i.e., Hotspot doesn’t expect errno the be accessed in Java code.
> 
> Thanks,
> -Sundar
> 



More information about the panama-dev mailing list