[vector] Unary/Ternary ops

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Thu Mar 1 21:28:05 UTC 2018


Al,

(Finally, I see your name in OCA Signatory List. Congrats and thanks for 
the contribution!)

I applied some cleanups to the original patch:
 
http://cr.openjdk.java.net/~vlivanov/panama/al_miftah/vector_ops/webrev.01

Razvan wrote:
 > - The integral types also have the comments " // Unary Operations" and
 > "// Ternary Operations" but no methods defined yet. Maybe those should
 > also be conditionally generated.

Since all concrete vector classes are generated from the same source, I 
find it useful to see section delimiters even if they are empty. So, I 
decided to leave it as is.

Best regards,
Vladimir Ivanov

On 2/14/18 9:12 PM, Al K wrote:
> Oops, wrong patch link, see
> http://cr.openjdk.java.net/~vlivanov/panama/al_miftah/vector_ops/webrev.00/index.html
> 
> On Wed, Feb 14, 2018 at 11:54 AM, Al K <someusername3 at gmail.com> wrote:
> 
>> http://cr.openjdk.java.net/~vlivanov/panama/vector.generalized_intrinsics/webrev.06/
>>
>>
>> This extends the generalized intrinsics changeset with the following:
>>
>> 1. General ternary ops - currently only fma
>>
>> 2. General unary ops - abs/neg/sqrt
>>
>>
>> I've replaced the previous inline_vector_binary_operation() in opto/library_call
>>
>> with a generic inline_vector_nary_operation() to avoid writing specialized impls
>>
>> for the various n-ary ops.
>>
>>
>> There's also a change in os/linux/os_linux to fix the pointer comparison so clang
>>
>> would stop complaining.
>>
>>
>> I've signed the OCA, awaiting for it to be reflected on the site.
>>
>>
>> Cheers,
>>
>> Al
>>
>>


More information about the panama-dev mailing list