RFR: [nicl] Further refactoring of java.nicl.Libraries.

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Tue Mar 6 11:55:55 UTC 2018


Webrev: 
http://cr.openjdk.java.net/~sundar/nicl_libraries_refactoring/webrev.00/index.html

* Removed @Deprecated on bind* methods of Libraries
* Removed native method handle methods of Libraries & associated 
security test
* createLayout moved as static factory 'create' method to LayoutType

Thanks,
-Sundar

On 06/03/18, 12:32 AM, Maurizio Cimadamore wrote:
> Looks good.
>
> As discussed offline, the next cleanup rounds would include:
>
> 1) get rid of @Deprecated methods in Libraries
>
> 2) either remove the MH lookup methods (I don't think they are used 
> externally), or move them someplace more suitable (e.g. an impl class 
> or, if they really need to be public, MethodHandles.Lookup)
>
> 3) LayoutType factory should be in LayoutType (static interface 
> method). It has nothing to do with 'libraries' :-)
>
> Thanks
> Maurizio
>
>
>
> On 05/03/18 14:28, Sundararajan Athijegannathan wrote:
>> Webrev: http://cr.openjdk.java.net/~sundar/nicl_library/webrev.00/
>>
>> Thanks,
>> -Sundar
>


More information about the panama-dev mailing list