RFR(L): Vector API Compare Intrinsics

[Paul Sandoz]

> On Mar 9, 2018, at 10:51 AM, Lupusoru, Razvan A <razvan.a.lupusoru at intel.com> wrote:
> 
> Instead of "toArray" on masks, what do you think of replacing/adding "intoArray”?

Yes, good idea. Add to the list of stuff to do.

Paul.


> That way we can also intrinsify that easily without making the creation of array part of semantics.
> 
> --Razvan
> 
> -----Original Message-----
> From: Paul Sandoz [mailto:paul.sandoz at oracle.com] 
> Sent: Friday, March 09, 2018 10:49 AM
> To: Lupusoru, Razvan A <razvan.a.lupusoru at intel.com>
> Cc: panama-dev at openjdk.java.net
> Subject: Re: RFR(L): Vector API Compare Intrinsics
> 
> 
> 
>> On Mar 9, 2018, at 10:24 AM, Lupusoru, Razvan A <razvan.a.lupusoru at intel.com> wrote:
>> 
>> Hi everyone,
>> 
>> Rahul and I have implemented all the code sequences for compares (<,>,<=,>=,==,!=) for all vector types and sizes. Please take a look at the patch:
>> http://cr.openjdk.java.net/~rlupusoru/panama/webrev_veccompares_04/
>> 
> 
> Java bits look good.
> 
> 
>> Please note that I also added the necessary tests to exercise this functionality. Likely they can be cleaned up once the infrastructure has a template for using data providers.
>> 
> 
> Yes. I would be tempted to write the mask results into an array and assert after the loop e.g. either store the booleans of the mask directly into a boolean array or do a blend-with-the-mask+store into a resulting element array (the advantage of the latter is an existing array assertion method can be reused). 
> 
> Paul.