[vector] tests with data providers
Halimi, Jean-Philippe
jean-philippe.halimi at intel.com
Wed Mar 14 21:38:09 UTC 2018
Hi Paul,
Sorry for the delayed answer. I think the patch looks good! I just have one remark:
- In Binary-Masked-op.template, is there a reason why you removed the 3 different mask types?
Jp
-----Original Message-----
From: panama-dev [mailto:panama-dev-bounces at openjdk.java.net] On Behalf Of Paul Sandoz
Sent: Monday, March 12, 2018 3:30 PM
To: panama-dev at openjdk.java.net
Subject: Re: [vector] tests with data providers
Patch rebased and updated for the comparison methods:
http://cr.openjdk.java.net/~psandoz/panama/tests-with-data-providers/webrev/
Paul.
> On Mar 9, 2018, at 5:12 PM, Paul Sandoz <Paul.Sandoz at oracle.com> wrote:
>
> Hi,
>
> Please review this patch to covert the vector tests to use TestNG data providers:
>
> http://cr.openjdk.java.net/~psandoz/panama/tests-with-data-providers/webrev/ <http://cr.openjdk.java.net/~psandoz/panama/tests-with-data-providers/webrev/>
>
> For now i took the simplest route placing them in the concrete tests rather than in a super class for a type shared across the shapes (in effect much in the header.template can be moved over to such a super class).
>
> Paul.
More information about the panama-dev
mailing list