[vector] tests with data providers
Vladimir Ivanov
vladimir.x.ivanov at oracle.com
Wed Mar 14 22:27:37 UTC 2018
Paul,
> Patch rebased and updated for the comparison methods:
>
> http://cr.openjdk.java.net/~psandoz/panama/tests-with-data-providers/webrev/
Have you looked into how new tests are optimized by C2?
My main concern is that the generators are opaque to the compiler. It
won't break intrinsification, but vector intructions will reside in tiny
stand-alone methods and there'll be excessive boxing/unboxing happening
unless C2 is able to inline the operations.
Best regards,
Vladimir Ivanov
>> On Mar 9, 2018, at 5:12 PM, Paul Sandoz <Paul.Sandoz at oracle.com> wrote:
>>
>> Hi,
>>
>> Please review this patch to covert the vector tests to use TestNG data providers:
>>
>> http://cr.openjdk.java.net/~psandoz/panama/tests-with-data-providers/webrev/ <http://cr.openjdk.java.net/~psandoz/panama/tests-with-data-providers/webrev/>
>>
>> For now i took the simplest route placing them in the concrete tests rather than in a super class for a type shared across the shapes (in effect much in the header.template can be moved over to such a super class).
>>
>> Paul.
>
More information about the panama-dev
mailing list