RFR [nicl] jextract: Adding long names for -t and -m. Adding tests for -t and -m

Henry Jen henry.jen at oracle.com
Tue Mar 20 15:15:22 UTC 2018


+1.

Cheers,
Henry


> On Mar 20, 2018, at 7:35 AM, Maurizio Cimadamore <maurizio.cimadamore at oracle.com> wrote:
> 
> Looks great, thanks!
> 
> Maurizio
> 
> 
> On 20/03/18 12:23, Sundararajan Athijegannathan wrote:
>> Updated: http://cr.openjdk.java.net/~sundar/jextract_package_map/webrev.01/
>> 
>> Thanks,
>> -Sundar
>> 
>> On 20/03/18, 4:05 PM, Maurizio Cimadamore wrote:
>>> Looks good; would it be possible to get rid of some of the code duplication in the test by moving common stuff to shared routines?
>>> 
>>> Thanks
>>> Maurizio
>>> 
>>> 
>>> On 20/03/18 10:21, Sundararajan Athijegannathan wrote:
>>>> Please review http://cr.openjdk.java.net/~sundar/jextract_package_map/webrev.00/index.html
>>>> 
>>>> * Adding long names --target-package and --package-map for -t and -m
>>>> * Added tests for -t and -m options.
>>>> 
>>>> Thanks
>>>> -Sundar
>>> 
> 



More information about the panama-dev mailing list