VectorAPI reduction operation support for testing infrastructure
Paul Sandoz
paul.sandoz at oracle.com
Fri Mar 30 15:57:48 UTC 2018
Hi,
> On Mar 30, 2018, at 7:11 AM, Halimi, Jean-Philippe <jean-philippe.halimi at intel.com> wrote:
>
> Hi,
>
> I have updated the webrev with a few more minor fixes and addressing your first comment. Paul, if you get the chance, please have a look at my answer to your second comment so that I can update it if necessary.
>
> http://cr.openjdk.java.net/~jphalimi/webrev_reduction_testing_v1.3/webrev/
>
That looks good.
I did reply to your second comment in a prior email, but i don’t want to block progress. How about you push and i propose an additional patch, sometimes that is easier/quicker way to communicate an idea?
I see you added an optional to the run script to disable the intrinsics. We can also add this to the jtreg meta-data:
@run testng/othervm $vectorteststype$
@run testng/othervm -XX:-UseVectorApiIntrinsics $vectorteststype$
(jtreg can accept additional JVM parameters on the command line, so i hesitated to add -XX:-TireredCompilation for now. See later.)
No need for another review if you add this.
Running with -Xcomp is also useful for stress testing, you might wanna consider adding that option to your run script at some point.
—
Separately, to consider later on, i think we need to remove the invocationCount parameter from @Test and embed such a loop in the tests themselves, with a configurable loop iteration value.
Thanks,
Paul.
More information about the panama-dev
mailing list