[foreign] RFR Refactoring Header and LibraryDependencies annotations into a single NativeLibrary annotation

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Wed May 16 12:07:30 UTC 2018


Looks good

Maurizio


On 16/05/18 12:50, Sundararajan Athijegannathan wrote:
>
> Oops! Updated -> 
> http://cr.openjdk.java.net/~sundar/nativelibrary_annotation_refactoring/webrev.01/
>
> Thanks,
> -Sundar
>
> On 16/05/18, 4:38 PM, Maurizio Cimadamore wrote:
>> Looks good - only nit is that the name of the consolidated anno is 
>> not consistent with the document, which speaks of @NativeHeader
>>
>> Maurizio
>>
>>
>> On 16/05/18 11:50, Sundararajan Athijegannathan wrote:
>>> * Refactoring Header and LibraryDependencies as a single annotation 
>>> called "NativeLibrary".
>>> * Removing unused 'native method handle' returning method in 
>>> LibrariesHelper.
>>>
>>> Webrev: 
>>> http://cr.openjdk.java.net/~sundar/nativelibrary_annotation_refactoring/webrev.00/
>>>
>>> Thanks,
>>> -Sundar
>>



More information about the panama-dev mailing list