VectorAPI Min and Max Reduction

[Paul Sandoz]

Nearly :-)

You need to change:

1753     public abstract $type$ minAll() {
1754         return rOp($Boxtype$.MAX_VALUE, (i, a, b) -> a > b ? b : a);
1755     }

to this:
  
1753     public abstract $type$ minAll();

If a Java method is marked abstract on a class then it has no implementation (and by definition the class has to be marked abstract as well).

And then you can run the generation script to generate updates to IntVector etc, and double check everything compiles (it should).

Paul.

> On May 17, 2018, at 4:08 PM, Rukmannagari, Shravya <shravya.rukmannagari at intel.com> wrote:
> 
> Hi Paul,
> Please let me know if this works!!
> http://cr.openjdk.java.net/~srukmannagar/VectorAPI_minmaxReduction/webrev.03/
> 
> Thanks,
> Shravya.
> 
> -----Original Message-----
> From: Paul Sandoz [mailto:paul.sandoz at oracle.com] 
> Sent: Thursday, May 17, 2018 3:55 PM
> To: Rukmannagari, Shravya <shravya.rukmannagari at intel.com>
> Cc: panama-dev at openjdk.java.net
> Subject: Re: VectorAPI Min and Max Reduction
> 
> Hi,
> 
> Much better!
> 
> Would you mind making the minAll/maxAll methods abstract on the public primitive Vector types (i.e. editing X-Vector.java.template)?
> 
> Thanks,
> Paul.
> 
>> On May 17, 2018, at 3:30 PM, Rukmannagari, Shravya <shravya.rukmannagari at intel.com> wrote:
>> 
>> Hi Paul,
>> I have made the changes suggested. Please find the updated patch here:
>> http://cr.openjdk.java.net/~srukmannagar/VectorAPI_minmaxReduction/webrev.02/
>> 
>> Thanks,
>> Shravya.
>> 
>> -----Original Message-----
>> From: Paul Sandoz [mailto:paul.sandoz at oracle.com] 
>> Sent: Tuesday, May 15, 2018 3:53 PM
>> To: Rukmannagari, Shravya <shravya.rukmannagari at intel.com>
>> Cc: panama-dev at openjdk.java.net
>> Subject: Re: VectorAPI Min and Max Reduction
>> 
>> Hi Shravya,
>> 
>> Some quick observations:
>> 
>> - the patch is missing the files for the new reduction templates.
>> 
>> - changes to gen-src.sh encode your own path to the Spp source.
>> 
>> - there is a bunch of unrelated test code that is incorrectly removed.
>> 
>> Paul.
>> 
>> 
>>> On May 15, 2018, at 1:10 PM, Rukmannagari, Shravya <shravya.rukmannagari at intel.com> wrote:
>>> 
>>> Hi All,
>>> 
>>> I would like to contribute a patch for min and max reduction vector intrinsics.  Could you please review the patch here:
>>> 
>>> http://cr.openjdk.java.net/~srukmannagar/VectorAPI_minmaxReduction/webrev.00/
>>> 
>>> 
>>> 
>>> Thanks,
>>> Shravya.
>>> 
>> 
>