VectorAPI Min and Max Reduction

[Vladimir Ivanov]

src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template:

-    public $type$ minAll() {
+    public abstract $type$ minAll() {
          return rOp($Boxtype$.MAX_VALUE, (i, a, b) -> a > b ? b : a);
      }

You have to remove the body as well. Also, updated primitive 
specializations of Vector are absent.

Otherwise, looks good.

Best regards,
Vladimir Ivanov

On 5/17/18 16:08, Rukmannagari, Shravya wrote:
> Hi Paul,
> Please let me know if this works!!
> http://cr.openjdk.java.net/~srukmannagar/VectorAPI_minmaxReduction/webrev.03/
> 
> Thanks,
> Shravya.
> 
> -----Original Message-----
> From: Paul Sandoz [mailto:paul.sandoz at oracle.com]
> Sent: Thursday, May 17, 2018 3:55 PM
> To: Rukmannagari, Shravya <shravya.rukmannagari at intel.com>
> Cc: panama-dev at openjdk.java.net
> Subject: Re: VectorAPI Min and Max Reduction
> 
> Hi,
> 
> Much better!
> 
> Would you mind making the minAll/maxAll methods abstract on the public primitive Vector types (i.e. editing X-Vector.java.template)?
> 
> Thanks,
> Paul.
> 
>> On May 17, 2018, at 3:30 PM, Rukmannagari, Shravya <shravya.rukmannagari at intel.com> wrote:
>>
>> Hi Paul,
>> I have made the changes suggested. Please find the updated patch here:
>> http://cr.openjdk.java.net/~srukmannagar/VectorAPI_minmaxReduction/webrev.02/
>>
>> Thanks,
>> Shravya.
>>
>> -----Original Message-----
>> From: Paul Sandoz [mailto:paul.sandoz at oracle.com]
>> Sent: Tuesday, May 15, 2018 3:53 PM
>> To: Rukmannagari, Shravya <shravya.rukmannagari at intel.com>
>> Cc: panama-dev at openjdk.java.net
>> Subject: Re: VectorAPI Min and Max Reduction
>>
>> Hi Shravya,
>>
>> Some quick observations:
>>
>> - the patch is missing the files for the new reduction templates.
>>
>> - changes to gen-src.sh encode your own path to the Spp source.
>>
>> - there is a bunch of unrelated test code that is incorrectly removed.
>>
>> Paul.
>>
>>
>>> On May 15, 2018, at 1:10 PM, Rukmannagari, Shravya <shravya.rukmannagari at intel.com> wrote:
>>>
>>> Hi All,
>>>
>>> I would like to contribute a patch for min and max reduction vector intrinsics.  Could you please review the patch here:
>>>
>>> http://cr.openjdk.java.net/~srukmannagar/VectorAPI_minmaxReduction/webrev.00/
>>>
>>>
>>>
>>> Thanks,
>>> Shravya.
>>>
>>
>