[foreign] RFR 8213518: jextract should support --include-symbols option
Maurizio Cimadamore
maurizio.cimadamore at oracle.com
Fri Nov 9 21:26:32 UTC 2018
Looks good. +1 on the careful testing, getting exclude with exclude is
tricky.
I wonder if the help message should be explict about the order in which
filters are applied.
Stepping back, as discussed privately, I think we have reached the end
of the road when it comes to the big toplevel @NativeHeader annotation,
and we will work towards breaking that up at the member level - which
seems to make more sense on a number of orthogonal axis (readability,
parseability from binder, scalabilty when symbols are many, reuse of
indentical desc strings).
Maurizio
On 09/11/2018 04:40, Sundararajan Athijegannathan wrote:
> jextract supports --exclude-symbols to filter out symbols from a
> header file. Sometimes we may want to include only specific symbols
> and exclude everything else. But it is bit difficult to write negative
> regexp filters with --exclude-symbols for such cases. It is better to
> have --include-symbols option as well.
>
> Please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8213518
> Webrev: https://cr.openjdk.java.net/~sundar/8213518/webrev.01/
>
> Thanks,
> -Sundar
More information about the panama-dev
mailing list