[vector] Template patch for Javadoc errors

Brian Goetz brian.goetz at oracle.com
Mon Nov 19 21:25:12 UTC 2018


More Javadoc bugs, patch inline:

diff -r 2ace5b3176f8 
src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java
--- 
a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java
+++ 
b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java
@@ -1572,7 +1572,7 @@
           * Tests if the lane at index {@code i} is set
           * @param i the lane index
           * @return true if the lane at index {@code i} is set, 
otherwise false
-         * @see getElement
+         * @see #getElement
           */
          public boolean isSet(int i) {
              return getElement(i);
@@ -1777,7 +1777,7 @@
       *
       * @param bitSize the size in bits
       * @return the shape corresponding to bitsize
-     * @see bitSize
+     * @see #bitSize
       */
      public static Shape shapeForVectorBitSize(int bitSize) {
          switch (bitSize) {



On 11/19/2018 3:58 PM, Brian Goetz wrote:
> See attached for a patch that fixes several Javadoc errors in the 
> generated template types.
>
> diff --git 
> a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template 
> b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template 
>
> old mode 100644
> new mode 100755
> --- 
> a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
> +++ 
> b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
> @@ -396,7 +396,7 @@
>       * This is a vector binary operation where the primitive division
>       * operation ({@code /}) is applied to lane elements.
>       *
> -     * @param v the input scalar
> +     * @param s the input scalar
>       * @return the result of dividing this vector by the broadcast of 
> an input
>       * scalar
>       */
> @@ -422,7 +422,7 @@
>       * This is a vector binary operation where the primitive division
>       * operation ({@code /}) is applied to lane elements.
>       *
> -     * @param v the input scalar
> +     * @param s the input scalar
>       * @param m the mask controlling lane selection
>       * @return the result of dividing this vector by the broadcast of 
> an input
>       * scalar
> @@ -1758,7 +1758,7 @@
>       * <p>
>       * This is an associative vector reduction operation where the 
> operation
>       * {@code (a, b) -> a > b ? b : a} is applied to lane elements,
> -     * and the identity value is {@link $Boxtype$.MAX_VALUE}.
> +     * and the identity value is {@link $Boxtype$#MAX_VALUE}.
>       *
>       * @return the minimum lane element of this vector
>       */
> @@ -1770,7 +1770,7 @@
>       * <p>
>       * This is an associative vector reduction operation where the 
> operation
>       * {@code (a, b) -> a > b ? b : a} is applied to lane elements,
> -     * and the identity value is {@link $Boxtype$.MAX_VALUE}.
> +     * and the identity value is {@link $Boxtype$#MAX_VALUE}.
>       *
>       * @param m the mask controlling lane selection
>       * @return the minimum lane element of this vector
> @@ -1782,7 +1782,7 @@
>       * <p>
>       * This is an associative vector reduction operation where the 
> operation
>       * {@code (a, b) -> a < b ? b : a} is applied to lane elements,
> -     * and the identity value is {@link $Boxtype$.MIN_VALUE}.
> +     * and the identity value is {@link $Boxtype$#MIN_VALUE}.
>       *
>       * @return the maximum lane element of this vector
>       */
> @@ -1794,7 +1794,7 @@
>       * <p>
>       * This is an associative vector reduction operation where the 
> operation
>       * {@code (a, b) -> a < b ? b : a} is applied to lane elements,
> -     * and the identity value is {@link $Boxtype$.MIN_VALUE}.
> +     * and the identity value is {@link $Boxtype$#MIN_VALUE}.
>       *
>       * @param m the mask controlling lane selection
>       * @return the maximum lane element of this vector
>



More information about the panama-dev mailing list