[vector] RFR: Fix for Javadoc bugs in vector API
Vladimir Ivanov
vladimir.x.ivanov at oracle.com
Wed Nov 28 02:29:21 UTC 2018
Looks good!
Best regards,
Vladimir Ivanov
PS: I see your name listed as Committer in Panama. Let me know if you
need any help with pushing the patch.
On 27/11/2018 15:29, Brian Goetz wrote:
> (reposting)
>
> Two patches that correct Javadoc errors in the Vector API:
>
> diff --git
> a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
> b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
>
> old mode 100644
> new mode 100755
> ---
> a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
>
> +++
> b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
>
> @@ -396,7 +396,7 @@
> * This is a vector binary operation where the primitive division
> * operation ({@code /}) is applied to lane elements.
> *
> - * @param v the input scalar
> + * @param s the input scalar
> * @return the result of dividing this vector by the broadcast of
> an input
> * scalar
> */
> @@ -422,7 +422,7 @@
> * This is a vector binary operation where the primitive division
> * operation ({@code /}) is applied to lane elements.
> *
> - * @param v the input scalar
> + * @param s the input scalar
> * @param m the mask controlling lane selection
> * @return the result of dividing this vector by the broadcast of
> an input
> * scalar
> @@ -1758,7 +1758,7 @@
> * <p>
> * This is an associative vector reduction operation where the
> operation
> * {@code (a, b) -> a > b ? b : a} is applied to lane elements,
> - * and the identity value is {@link $Boxtype$.MAX_VALUE}.
> + * and the identity value is {@link $Boxtype$#MAX_VALUE}.
> *
> * @return the minimum lane element of this vector
> */
> @@ -1770,7 +1770,7 @@
> * <p>
> * This is an associative vector reduction operation where the
> operation
> * {@code (a, b) -> a > b ? b : a} is applied to lane elements,
> - * and the identity value is {@link $Boxtype$.MAX_VALUE}.
> + * and the identity value is {@link $Boxtype$#MAX_VALUE}.
> *
> * @param m the mask controlling lane selection
> * @return the minimum lane element of this vector
> @@ -1782,7 +1782,7 @@
> * <p>
> * This is an associative vector reduction operation where the
> operation
> * {@code (a, b) -> a < b ? b : a} is applied to lane elements,
> - * and the identity value is {@link $Boxtype$.MIN_VALUE}.
> + * and the identity value is {@link $Boxtype$#MIN_VALUE}.
> *
> * @return the maximum lane element of this vector
> */
> @@ -1794,7 +1794,7 @@
> * <p>
> * This is an associative vector reduction operation where the
> operation
> * {@code (a, b) -> a < b ? b : a} is applied to lane elements,
> - * and the identity value is {@link $Boxtype$.MIN_VALUE}.
> + * and the identity value is {@link $Boxtype$#MIN_VALUE}.
> *
> * @param m the mask controlling lane selection
> * @return the maximum lane element of this vector
>
>
> diff -r 2ace5b3176f8
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java
> ---
> a/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java
> +++
> b/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java
> @@ -1572,7 +1572,7 @@
> * Tests if the lane at index {@code i} is set
> * @param i the lane index
> * @return true if the lane at index {@code i} is set,
> otherwise false
> - * @see getElement
> + * @see #getElement
> */
> public boolean isSet(int i) {
> return getElement(i);
> @@ -1777,7 +1777,7 @@
> *
> * @param bitSize the size in bits
> * @return the shape corresponding to bitsize
> - * @see bitSize
> + * @see #bitSize
> */
> public static Shape shapeForVectorBitSize(int bitSize) {
> switch (bitSize) {
>
More information about the panama-dev
mailing list