[foreign] RFR 8211277: Exception when dereferencing null pointer should be more specific

[Maurizio Cimadamore]

Thanks,
I've removed Windows specific #defines and pushed the changeset.

Maurizio


On 01/10/18 10:24, Sundararajan Athijegannathan wrote:
> Yes, would be nice to have it consistent & revisit the macro for all 
> tests later as you mentioned.
>
> -Sundar
>
> On 01/10/18, 2:40 PM, Jorn Vernee wrote:
>> Sundararajan Athijegannathan schreef op 2018-10-01 05:06:
>>> Looks good.
>>>
>>> PS. While I'm fine with the Windows portability EXPORT macro in C
>>> code, none of the other existing tests use this. Perhaps we need
>>> similar such portability macro elsewhere? Not suggesting for current
>>> changeset though.
>>
>> I have them in my local copy for every test, I could make a patch for 
>> those as well, but without wider Windows support they're not as 
>> meaningful to have right now. Maybe the one in this changeset should 
>> be removed as well to be added in later with all the others.
>>
>>> -Sundar
>>>
>>>
>>> On 28/09/18, 6:35 PM, Maurizio Cimadamore wrote:
>>>> Hi,
>>>> this is a RFR for the changes discussed in [1] (again, thanks 
>>>> Jorn!). Some minor tweaks:
>>>>
>>>> * consolidate the code paths for 'throwy' References - new 
>>>> Reference.OfGrumpy :-)
>>>>
>>>> * tweaked test to check the exception cause - as otherwise the test 
>>>> passes even w/o the fix
>>>>
>>>> Webrev:
>>>>
>>>> http://cr.openjdk.java.net/~mcimadamore/panama/8211277/
>>>>
>>>> Cheers
>>>> Maurizio
>>>>
>>>> [1] - 
>>>> http://mail.openjdk.java.net/pipermail/panama-dev/2018-September/002796.html
>>>>