[foreign] RFR 8212061: Fix jextract command line errors and crashes

Henry Jen henry.jen at oracle.com
Fri Oct 12 02:31:49 UTC 2018


Sorry I was not clear, I meant the behavior with out input file. Was wondering why not print usage.

Cheers,
Henry

> On Oct 11, 2018, at 7:39 PM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
> 
> Am I missing something? javac produces .class on the same dir where .java was found - in other words, javac's behaviour is similar jextract (before this patch).
> 
> -Sundar
> 
> On 12/10/18, 12:55 AM, Henry Jen wrote:
>> Looks good. This is same behavior as javac.
>> 
>> Cheers,
>> Henry
>> 
>> 
>>> On Oct 11, 2018, at 10:35 AM, Maurizio Cimadamore<maurizio.cimadamore at oracle.com>  wrote:
>>> 
>>> This patch fixes two further problems with the jextract tool:
>>> 
>>> 1) jextract will attempt to generate a jarfile where the extracted header is - if that is a system header, this leads to permission issues (e.g. cannot write to xyz)
>>> 2) If some option is used but no actual header file is specified, jextract crashes with exception
>>> 
>>> 
>>> (1) has been addressed by using working dir, which should lead to more predictable behavior. (2) has been fixed by checking for absence of input files, and issuing an error if that happens.
>>> 
>>> Webrev:
>>> 
>>> http://cr.openjdk.java.net/~mcimadamore/panama/8212061/
>>> 
>>> Cheers
>>> Maurizio
>>> 



More information about the panama-dev mailing list