[foreign] RFR 8212560 : jextract should generate a static forwarder class

[Maurizio Cimadamore]

I like it! Few questions/comments:

* should it be enabled/disabled with explicit option
* should the name of the statics class be customizable
* I like the code organization - have you thought of pushing it further 
and make StaticForwarderGenerator a _subclass_ of AsmCodeFactory - each 
visitor could maybe delegate to super.visitXyz() first and then do its 
own bit? Then when you setup the pipeline, depending on what info is 
available on the context (e.g. presence of -l) you can decide whether to 
use a 'bare' ASMCodeFactory or the 'embellished' one. That should remove 
all the 'if staticFwd != null ...' sections from AsmCodeFactory.

Maurizio


On 17/10/2018 06:35, Sundararajan Athijegannathan wrote:
> Please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8212560
> Webrev: http://cr.openjdk.java.net/~sundar/8212560/webrev.00/index.html
>
> Thanks,
> -Sundar