RFR: [panama foreign] Build tweak to enable build on Windows

Erik Joelsson erik.joelsson at oracle.com
Fri Oct 26 16:05:44 UTC 2018


Hello Henry,

lib-clang.mr4:

I think you need to restore CXX and CXXCPP after the tests. Otherwise 
they will show up with double fixpath in spec.gmk.

I think the TOOLCHAIN_TYPE != microsoft "if" blocks should be inverted 
and flipped for easier reading.

Otherwise I think this looks ok.

/Erik

On 2018-10-25 21:44, Henry Jen wrote:
> Hi,
>
> Please review a web rev[1] that address following,
>
> 1. Copy the essential share library as recorded by the linker following the symbolic link of libclang.so for unix/mac. This leads to only one copy of share library instead of a duplicate copy of libclang.so. It would be nice to have create libclang as a symbolic link, but it’s not needed now.
>
> This issue is what failed the build when using system provided libclang on some systems such as Debian-based Linux distribution. After this patch, Debian-based system can be build as described in README.foreign.
>
> 2. Enable build on Windows. This patch allow build image to be completed successfully and libclang.dll copied to bin as expected.
>
> However, this doesn’t mean binder is working on Windows, it’s simply get the build going and jextract should be functional. Some test still have compiling errors to be fixed, and we don’t have Windows ABI. It’s the first step to allow build on Windows.
>
> I believe a lot of this had been addressed by Jorn, and he actually have made more progress on Windows support. Hopefully this is just the first step and get Windows going.
>
> Cheers,
> Henry
>
> [1] http://cr.openjdk.java.net/~henryjen/panama/build-windows/webrev
>
>



More information about the panama-dev mailing list