[vector api] RFR: Implement Vector API abs and not for AArch64 NEON

Yang Zhang (Arm Technology China) Yang.Zhang at arm.com
Wed Oct 31 03:56:44 UTC 2018


Vladimir

Thanks very much.

Regards
Yang

-----Original Message-----
From: Vladimir Ivanov <vladimir.x.ivanov at oracle.com> 
Sent: Tuesday, October 30, 2018 6:20 AM
To: Yang Zhang (Arm Technology China) <Yang.Zhang at arm.com>; panama-dev at openjdk.java.net
Cc: nd <nd at arm.com>
Subject: Re: [vector api] RFR: Implement Vector API abs and not for AArch64 NEON

Yang,

I'm not AArch64 expert, but it looks fine. Pushed [1]

Best regards,
Vladimir Ivanov

[1] http://hg.openjdk.java.net/panama/dev/rev/ae8a17841a0c

PS: Vector API project policies (in particular and Project Panama policies in general) are lax compared to jdk, so there's no formal requirement to review the changes before the push (still it's a good habit). Once you have Committer rights in the Project, there won't be any need to review Arm-specific code unless you are looking for a feedback. Reviewing & coordingating changes in shared code will still be needed because they may affect many others working on the project.

On 29/10/2018 01:01, Yang Zhang (Arm Technology China) wrote:
> Hi,
> 
> I have a patch which implement Vector API abs() and not() for AArch64 NEON.
> Could you please help to review this?
> 
> Webrev:
> http://cr.openjdk.java.net/~yzhang/vectorapi.abs_not/webrev.00/
> 
> Regards,
> Yang
> 


More information about the panama-dev mailing list