[foreign] RFR 8210935 C enum constants should be mapped to interface methods instead of static final int constants

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Thu Sep 20 17:16:09 UTC 2018


Looks good!

Maurizio


On 20/09/18 16:22, Sundararajan Athijegannathan wrote:
> Thanks. I've added few more tests to combine enum constants.
>
> Pushing this updated changes: 
> http://cr.openjdk.java.net/~sundar/8210935/webrev.01/
>
> -Sundar
>
> On 20/09/18, 8:26 PM, Maurizio Cimadamore wrote:
>> Looks good.
>>
>> Maybe in the test you could also check that e.g. combining enum 
>> constants in Java and C yields the same - e.g.
>>
>> R | G
>>
>> ?
>>
>> Maurizio
>>
>>
>>
>> On 20/09/18 06:15, Sundararajan Athijegannathan wrote:
>>> Please review.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210935
>>> Webrev: http://cr.openjdk.java.net/~sundar/8210935/webrev.00/
>>>
>>> Thanks,
>>> -Sundar
>>



More information about the panama-dev mailing list