[foreign] RFR 8221911: jextract source generator misses NativeLocation annotation for struct interfaces

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Wed Apr 3 15:38:53 UTC 2019


Ah ok :-)

That looks good.

Maurizio

On 03/04/2019 16:12, Sundararajan Athijegannathan wrote:
> Forgot to mention that. I refactored TypedefHandler code to use 
> "flatMap" in first part (instead of forEach in earlier patch) and use 
> comuteIfAbsent in the second part (to avoid containsKey check and 
> if..else).
>
> -Sundar
>
> On 03/04/19, 7:54 PM, Maurizio Cimadamore wrote:
>> The nativeLocation change looks ok, but TypedefHandler seems to 
>> repeat the same changes as in your earlier patch?
>>
>> Maurizio
>>
>> On 03/04/2019 14:43, Sundararajan Athijegannathan wrote:
>>> Please review.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221911
>>> Webrev: 
>>> https://cr.openjdk.java.net/~sundar/8221911/webrev.00/index.html
>>>
>>> Thanks,
>>> -Sundar


More information about the panama-dev mailing list